Fix canonical nan test function #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appcypher
changed the title
syrusakbary
added a commit
that referenced
this pull request
Aug 1, 2019
Each time `make capi` is run, there is a flaky error:
```
Running target/release/deps/runtime_c_api_tests-3df0f74fcea1252d
running 1 test
test test_c_api ... FAILED
failures:
---- test_c_api stdout ----
Running command: `cmake` arg: Some(".")
output:
status: 0
stdout:
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/syrusakbary/Development/wasmer/lib/runtime-c-api/tests
stderr:
Running command: `make` arg: Some("-Wdev -Werror=dev")
output:
status: 0
stdout:
[ 7%] Built target test-tables
[ 15%] Built target test-module-exports
[ 23%] Built target test-module-imports
[ 30%] Built target test-globals
[ 38%] Built target test-imports
[ 46%] Built target test-module
[ 53%] Built target test-module-serialize
[ 61%] Built target test-memory
[ 69%] Built target test-validate
[ 76%] Built target test-import-function
[ 84%] Built target test-instantiate
[ 92%] Built target test-exports
[100%] Built target test-exported-memory
stderr:
Running command: `make` arg: Some("test")
output:
status: 2
stdout:
Running tests...
Test project /Users/syrusakbary/Development/wasmer/lib/runtime-c-api/tests
Start 1: test-exported-memory
1/13 Test #1: test-exported-memory .............Child aborted***Exception: 0.00 sec
Start 2: test-exports
2/13 Test #2: test-exports ..................... Passed 0.01 sec
Start 3: test-globals
3/13 Test #3: test-globals ..................... Passed 0.00 sec
Start 4: test-import-function
4/13 Test #4: test-import-function ............. Passed 0.01 sec
Start 5: test-imports
5/13 Test #5: test-imports ..................... Passed 0.01 sec
Start 6: test-instantiate
6/13 Test #6: test-instantiate ................. Passed 0.01 sec
Start 7: test-memory
7/13 Test #7: test-memory ...................... Passed 0.00 sec
Start 8: test-module
8/13 Test #8: test-module ...................... Passed 0.01 sec
Start 9: test-module-exports
9/13 Test #9: test-module-exports .............. Passed 0.01 sec
Start 10: test-module-imports
10/13 Test #10: test-module-imports .............. Passed 0.01 sec
Start 11: test-module-serialize
11/13 Test #11: test-module-serialize ............ Passed 0.01 sec
Start 12: test-tables
12/13 Test #12: test-tables ...................... Passed 0.00 sec
Start 13: test-validate
13/13 Test #13: test-validate .................... Passed 0.00 sec
92% tests passed, 1 tests failed out of 13
Total Test time (real) = 0.08 sec
The following tests FAILED:
1 - test-exported-memory (Child aborted)
stderr:
Errors while running CTest
make[1]: *** [test] Error 8
thread 'test_c_api' panicked at 'Command failed with exit status: ExitStatus(ExitStatus(512))', lib/runtime-c-api/tests/runtime_c_api_tests.rs:43:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
```
MarkMcCaskey
pushed a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How should this be manually tested?
cargo testBackground context
The previous
is_canonical_nanimplementation checks if the mantissa bits are set when it should actually be checking if they are unset.Makes me wonder how the tests were passing previously 🤔