Remove special casing of stdin, stdout, and stderr in WASI FS #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
|
bors try- |
MarkMcCaskey
force-pushed
the
fix/wasi-stdin-stdout-stderr-are-in-fd-map
branch
from
7b2ce01
to
3a87edc
Compare
|
bors try |
syrusakbary
approved these changes
Oct 23, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 23, 2019
897: Remove special casing of stdin, stdout, and stderr in WASI FS r=MarkMcCaskey a=MarkMcCaskey # Description Properly fixes closing stdin, stdout, stderr. Cleans up this part of the code while it's at it. This PR introduces breaking changes to the pubic WASI API # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <mark@wasmer.io>
tryBuild succeeded
|
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Properly fixes closing stdin, stdout, stderr. Cleans up this part of the code while it's at it.
This PR introduces breaking changes to the pubic WASI API
Review