feat(runtime-c-api) Add support for clang in WASMER_H_MACROS
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
commented
Nov 13, 2019
lib/runtime-c-api/build.rs
Outdated
| #ifdef __x86_64__ | ||
| #define ARCH_X86_64 | ||
| #endif | ||
| #if defined(GCC) || defined(__clang__) |
There was a problem hiding this comment.
Bug fix is here: defined(__clang__).
Hywan
added a commit
to wasmerio/wasmer-php
that referenced
this pull request
Nov 13, 2019
This patch updates the shared libraries to Wasmer 0.10.1. The `wasmer.hh` file includes this bug fix, wasmerio/wasmer#960.
|
bors try |
tryBuild succeeded
|
…com:Hywan/wasmer into fix-runtime-c-api-header-preprocessor-clang
MarkMcCaskey
approved these changes
Nov 14, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2019
960: feat(runtime-c-api) Add support for clang in `WASMER_H_MACROS` r=MarkMcCaskey a=Hywan In #952, the `WASMER_H_MACROS` constant has been defined. The `ARCH_X86_64` constant is defined under 2 conditions: If the compiler is MSVC + `_M_AMD64` is defined, or if the compiler is GCC + `__x86_64__` is defined. Clang is missing. And it breaks some projects (like https://github.com/wasmerio/php-ext-wasm or https://github.com/wasmerio/go-ext-wasm for instance). This patch supports Clang. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #952, the
WASMER_H_MACROSconstant has been defined. TheARCH_X86_64constant is defined under 2 conditions: If the compiler is MSVC +_M_AMD64is defined, or if the compiler is GCC +__x86_64__is defined.Clang is missing. And it breaks some projects (like https://github.com/wasmerio/php-ext-wasm or https://github.com/wasmerio/go-ext-wasm for instance).
This patch supports Clang.