When accessing memory, use byte aligned accesses. #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjfish
approved these changes
Nov 15, 2019
|
bors r+ |
Merge conflict |
LLVM's instcombine will attempt to bump the alignment when it can prove that it's safe to do so. Fixes #969.
nlewycky
force-pushed
the
features/llvm-byte-aligned-accesses
branch
from
8ba3add
to
ecc82a7
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 15, 2019
971: When accessing memory, use byte aligned accesses. r=nlewycky a=nlewycky # Description When accessing memory, use byte aligned accesses. LLVM's instcombine will attempt to bump the alignment when it can prove that it's safe to do so. Fixes #969. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Nick Lewycky <nick@wasmer.io>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When accessing memory, use byte aligned accesses.
LLVM's instcombine will attempt to bump the alignment when it can prove that it's safe to do so.
Fixes #969.
Review