State fixes and improvements #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zer0main
force-pushed
the
go-62-sync-state
branch
3 times, most recently
from
7a47e05
to
5546101
Compare
zer0main
force-pushed
the
go-62-sync-state
branch
2 times, most recently
from
f1cdcc7
to
d0f7f09
Compare
These changes must be written directly to DB, because deleting outdated records always makes sense.
zer0main
force-pushed
the
go-62-sync-state
branch
from
d0f7f09
to
fc78a97
Compare
See comment.
Successfully tested possibility to continue importing after Ctrl-C termination.
zer0main
force-pushed
the
go-62-sync-state
branch
from
3ca8135
to
353cc77
Compare
zer0main
force-pushed
the
go-62-sync-state
branch
from
7c7fe73
to
35a8926
Compare
The problem is that |
alexeykiselev
requested changes
Feb 19, 2019
Remove separate tx IDs file. Use main blockchain file to get IDs to remove.
alexeykiselev
approved these changes
Feb 19, 2019
Frozen
pushed a commit
that referenced
this pull request
Mar 4, 2019
* Sync [wip] * Accounts storage: fix filterHistory() These changes must be written directly to DB, because deleting outdated records always makes sense. * BlockReadWriter: do not remove tx IDs in rollback See comment. * Add option to apply from certain height Successfully tested possibility to continue importing after Ctrl-C termination. * Accounts storage: do not store more than ROLLBACK_MAX blocks * GO-61: Reduntan mutex removed (#75) * GO-63: Correct termination, fixed binary search, fixed error messages and return codes (#76) * Rollback(): remove transaction IDs correctly Remove separate tx IDs file. Use main blockchain file to get IDs to remove. * Use camelCase for constants * Importer: use fixed-size byte array for block * Combine all related packages into single state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.