Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove rfkill switch support #254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aadilshabier
Copy link
Contributor

@aadilshabier aadilshabier commented Mar 10, 2024

Fix #174

The previous fix(0af3d0d) of disabling rfkill-input does not work anymore, this results in the wifi device turning off when starting swhkd.

The previous fix(0af3d0d) of disabling rfkill-input does not work anymore, this results in the wifi device turning off when starting swhkd.
@aadilshabier aadilshabier changed the title [fix] remove rfkill switch support (#174) [fix] remove rfkill switch support Mar 10, 2024
@Shinyzenith
Copy link
Member

CC: @zubairmh Thoughts?

@id3v1669
Copy link

id3v1669 commented Apr 3, 2024

CC: @zubairmh Thoughts?

Maybe it's better to make it optional to keep support for distros that need it?

@zubairmh
Copy link

zubairmh commented Apr 3, 2024

CC: @zubairmh Thoughts?

Maybe it's better to make it optional to keep support for distros that need it?

Most distro's seem to be unaffected, if someone is able to confirm that their distro is affected then it might be considerable.

It also seems inconsistent to have rfkill switch support for one distro and not for others

@Shinyzenith
Copy link
Member

Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.

Does that sound acceptable? CC: @id3v1669

@id3v1669
Copy link

id3v1669 commented Apr 7, 2024

Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.

Does that sound acceptable? CC: @id3v1669

Just tested on 5 distros:

Distro wifi dies with rfkill wifi dies without rfkill
Opensuse(Tumbleweed) + +
NixOS(unstable) - +
NixOS(unstable) * -
Debian 12 - +
Alpine * -

* doesn't work with rfkill at all

If your tests show that other distros are not affected by removing rfkill, it's ok to merge.
In rare cases, the patch can be applied during packaging.

@aadilshabier
Copy link
Contributor Author

Hey, @id3v1669
I'm having trouble understanding the table. Does the second column mean that wifi dies even after removing SW_RFKILL_ALL from the list of switches?

@id3v1669
Copy link

id3v1669 commented Apr 16, 2024

Hey, @id3v1669 I'm having trouble understanding the table. Does the second column mean that wifi dies even after removing SW_RFKILL_ALL from the list of switches?

Yes, second column mean that wifi dies even after removing SW_RFKILL_ALL .
No idea why that is happening, but on different devices I've got different behavior with same configuration.
This table works for Thinkpad L14 Gen 3 with intel AX210/AX1675 wifi module.
On Intel Nuc 11 PH with intel AX201 behavior is different and results are not in table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

pkexec swhkd turn off the wifi on start
4 participants