Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] Exit on SIGINT ( Control + c ). #77

Merged
merged 2 commits into from
Mar 6, 2022
Merged

[update] Exit on SIGINT ( Control + c ). #77

merged 2 commits into from
Mar 6, 2022

Conversation

Shinyzenith
Copy link
Member

No description provided.

@Shinyzenith Shinyzenith self-assigned this Mar 6, 2022
@Shinyzenith Shinyzenith added the Enhancement New feature or request label Mar 6, 2022
angelofallars
angelofallars approved these changes Mar 6, 2022
View reviewed changes
Copy link
Contributor

@angelofallars angelofallars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a message on exit as well, to make it more clear why swhkd stopped.

@Shinyzenith
Copy link
Member Author

I think we should merge this given it's a trivial change, I don't think eden will mind. What do you think? @angelofallars.

@angelofallars
Copy link
Contributor

I think we should merge this given it's a trivial change, I don't think eden will mind. What do you think? @angelofallars.

Yes, we should merge now.

@Shinyzenith Shinyzenith merged commit 6046f14 into main Mar 6, 2022
@Shinyzenith Shinyzenith deleted the remove_temp_pause branch March 8, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelofallars angelofallars angelofallars approved these changes

@vainiovano vainiovano Awaiting requested review from vainiovano

@EdenQwQ EdenQwQ Awaiting requested review from EdenQwQ

Assignees

@Shinyzenith Shinyzenith

Labels
Enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shinyzenith @angelofallars