Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A major version release update #181

Closed
wants to merge 8 commits into from

Conversation

awesor
Copy link
Contributor

@awesor awesor commented Feb 2, 2024

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

So as far as I can tell, this is a non-breaking major version upgrade for the Aerospike Client. I am not 100% certain in what this release contains given the lack of documentation on the Aerospike side, but this seems to mostly be a refactor on their end: aerospike/aerospike-client-csharp@c9b39e3?diff=split&w=1

Unfortunately, without that extra information (request sent out to the team to find out more), I'm just going based off of our robust tests and reading the above commit. From what I can tell however, there are a lot of changes from cleanup, refactor, and actual feature changes.

For example: Disposal Management?

The only "Breaking Change" according to the website (here) could impact us with Aerospike boolean particle type which I will look into a bit more.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce2f061) 83.34% compared to head (5f99ce3) 83.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files          65       65           
  Lines        1927     1927           
  Branches       76       76           
=======================================
  Hits         1606     1606           
  Misses        304      304           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awesor awesor marked this pull request as draft February 2, 2024 03:17
@awesor awesor marked this pull request as ready for review February 2, 2024 13:47
@awesor awesor closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant