Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail pipeline on first exception #379

Merged
merged 2 commits into from
Feb 18, 2023
Merged

Conversation

jashparekh
Copy link
Collaborator

Summary

TODO: What does this PR do? (Replace with summary!)

Other Information

TODO (if relevant)

PR Checklist

Please run through before submitting for final review:

  • The PR title is descriptive of what changed.
  • The description sections above are filled out.
  • The CI pipeline is passing
  • Added the ready-for-review label to the PR.

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #379 (6096053) into main (4558c3d) will decrease coverage by 1.34%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   66.19%   64.86%   -1.34%     
==========================================
  Files           3        3              
  Lines          71       74       +3     
  Branches       12       13       +1     
==========================================
+ Hits           47       48       +1     
- Misses         22       24       +2     
  Partials        2        2              
Impacted Files Coverage Δ
plugin_scripts/deploy.py 64.17% <33.33%> (-1.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jashparekh jashparekh merged commit e7eb02a into main Feb 18, 2023
@jashparekh jashparekh deleted the jparekh1_error_out_on_failure branch February 18, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant