Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for stopping dags in terminal state #52

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

patkivikram
Copy link
Collaborator

@patkivikram patkivikram commented Oct 4, 2023

Description

Fix to not call stop for DAG's in terminal states
Fixes #51

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #52 (5844c11) into main (35a0b1e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files          12       12           
  Lines        1824     1824           
  Branches      215      215           
=======================================
  Hits         1578     1578           
  Misses        146      146           
  Partials      100      100           
Files Coverage Δ
dagger/tasks/task.py 79.37% <ø> (ø)

@patkivikram patkivikram changed the title fix https://github.com/wayfair-incubator/dagger/issues/51 fix for stopping dags in terminal state Oct 4, 2023
@patkivikram patkivikram merged commit 3318025 into main Oct 4, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dagger stops a workflow in terminal state
2 participants