Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breadcrumb styles for Wazuh Dashboard based on OSD 2.3.x #4649

Merged
merged 9 commits into from
Oct 19, 2022
Merged

Fix breadcrumb styles for Wazuh Dashboard based on OSD 2.3.x #4649

merged 9 commits into from
Oct 19, 2022

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Oct 5, 2022 •
edited by yenienserrano
Loading

Description

This PR resolves the breadcrumb style for OpenSearch 2.x.

Closes #4502

Evidence

  • Before

image

  • After
    image

Test

Go to the Wazuh plugin and navigate to For instance: Modules > Integrity Monitoring.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl requested a review from a team as a code owner October 5, 2022 18:24
@Machi3mfl Machi3mfl changed the title Fix style in wazuh breadcrumb for osd 2.x Fixed style in wazuh breadcrumb for osd 2.x Oct 5, 2022
@Machi3mfl Machi3mfl self-assigned this Oct 5, 2022
@AlexRuiz7 AlexRuiz7 linked an issue Oct 6, 2022 that may be closed by this pull request
Wrong behavior from the Flyout component in Wazuh Dashboard 2.x #4597
Closed
11 tasks
@AlexRuiz7 AlexRuiz7 changed the title Fixed style in wazuh breadcrumb for osd 2.x Fix breadcrumb styles for Wazuh Dashboard based on OSD 2.3.x Oct 6, 2022
@Machi3mfl Machi3mfl removed a link to an issue Oct 6, 2022
Wrong behavior from the Flyout component in Wazuh Dashboard 2.x #4597
Closed
11 tasks
@Machi3mfl Machi3mfl linked an issue Oct 6, 2022 that may be closed by this pull request
Broken breadcrumbs in Wazuh Dashboard 2.x #4502
Closed
@AlexRuiz7 AlexRuiz7 marked this pull request as draft October 14, 2022 11:17
@yenienserrano
Copy link
Member

I was looking at mimicking opensearch dashboard styles to do the breadcrumb, and found that the tooltip was looking different on one agent name than any other, so to maintain consistency and avoid DOM modifications as was being done, I matched the agent name tooltip to how the others looked.

@yenienserrano
Copy link
Member

@yenienserrano yenienserrano self-assigned this Oct 14, 2022
@yenienserrano yenienserrano marked this pull request as ready for review October 14, 2022 13:56
asteriscos
asteriscos reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Possible minor improvements
Test: ✔️

image

public/components/common/globalBreadcrumb/globalBreadcrumb.scss Outdated Show resolved Hide resolved
public/components/common/globalBreadcrumb/globalBreadcrumb.tsx Outdated Show resolved Hide resolved
@Mayons95 Mayons95 self-requested a review October 18, 2022 13:41
Mayons95
Mayons95 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Mayons95 Mayons95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TR: ✔️

image (6)

image (5)

@mauceballos
Copy link
Contributor

LGTM

TR: ✔️

image (4)
image (5)

AlexRuiz7
AlexRuiz7 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code review: ✔️
  • Test: ✔️

@AlexRuiz7 AlexRuiz7 merged commit 8e6f25a into 4.4-1.2-wzd Oct 19, 2022
@AlexRuiz7 AlexRuiz7 deleted the bugfix/4502-fix-breadcrumb-style-osd2x branch October 19, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@asteriscos asteriscos asteriscos left review comments

@Mayons95 Mayons95 Mayons95 approved these changes

@mauceballos mauceballos mauceballos approved these changes

@AlexRuiz7 AlexRuiz7 AlexRuiz7 approved these changes

Assignees

@Machi3mfl Machi3mfl

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken breadcrumbs in Wazuh Dashboard 2.x
7 participants
@Machi3mfl @yenienserrano @mauceballos @asteriscos @AlexRuiz7 @Desvelao @Mayons95