Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove virustotal feature and dashboards in favor of malware dashboard #7038

Open
wants to merge 9 commits into
base: 4.10.0
Choose a base branch
from

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 30, 2024

Description

VirusTotal feature and dashboards: We want to remove this section, as it is included in the new malware dashboard

Issues Resolved

#7027

Evidence

Before

Screenshot_20240930_110640

After

image

Test

Navigate to the overview page and ensure that the VirusTotal feature and dashboards do not exist.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli self-assigned this Sep 30, 2024
@guidomodarelli guidomodarelli changed the base branch from master to 4.10.0 September 30, 2024 14:09
@guidomodarelli guidomodarelli force-pushed the change/7027-remove-virustotal-feature-and-dashboards-in-favor-of-malware-dashboard branch from 17248d1 to 076d338 Compare September 30, 2024 15:03
@guidomodarelli guidomodarelli linked an issue Sep 30, 2024 that may be closed by this pull request
6 tasks
@guidomodarelli guidomodarelli mentioned this pull request Sep 30, 2024
6 tasks
Machi3mfl
Machi3mfl previously approved these changes Sep 30, 2024
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Before

Screenshot 2024-09-30 at 2 15 58 PM

After

Screenshot 2024-09-30 at 2 15 43 PM

JuanGarriuz
JuanGarriuz previously approved these changes Oct 2, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

image

@JuanGarriuz JuanGarriuz self-requested a review October 2, 2024 06:57
@JuanGarriuz JuanGarriuz self-requested a review October 2, 2024 07:00
JuanGarriuz
JuanGarriuz previously approved these changes Oct 3, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Main plugin code coverage (Jest) test % values
Statements 14.1% ( 4172 / 29578 )
Branches 9.23% ( 1779 / 19261 )
Functions 13.78% ( 985 / 7144 )
Lines 14.29% ( 4070 / 28464 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the overview page
4 participants