Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change register agent styles #7149

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Change register agent styles #7149

merged 5 commits into from
Nov 14, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Nov 13, 2024 •
edited
Loading

Description

Change the styles of the agent view so it does not look like a modal

Issues Resolved

Evidence

screencapture-localhost-5601-app-endpoints-summary-2024-11-14-13_44_32

Test

Navigate to register agent view and check changes

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano linked an issue Nov 13, 2024 that may be closed by this pull request
Redesign deploy new agent page #7071
Closed
@chantal-kelm chantal-kelm self-requested a review November 13, 2024 19:32
chantal-kelm
chantal-kelm previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Captura de pantalla 2024-11-13 a la(s) 4 31 35 p  m Captura de pantalla 2024-11-13 a la(s) 4 32 26 p  m Captura de pantalla 2024-11-13 a la(s) 4 32 42 p  m Captura de pantalla 2024-11-13 a la(s) 4 32 37 p  m

@JuanGarriuz JuanGarriuz self-requested a review November 14, 2024 07:33
@JuanGarriuz
Copy link
Member

CR 🟢

Test 🟢

image
image
image
image
image
image

JuanGarriuz
JuanGarriuz previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Desvelao
Copy link
Member

Desvelao commented Nov 14, 2024 •
edited
Loading

suggestion: I think we should remove the rendered back button. The browser back button should do the work. The view is accessible from URL, but the rendered back button is redirecting to Endpoints Summary instead of the previous visited page. Moreover, I think rendering the back button makes to think I am viewing some subview of the page instead a separated page (use own URL).

The user could use the link (Endpoints) of the breadcrumb to go to the same view that the current rendered back button does.

Comparing with other views, we do not usually use the rendered back button.

asteriscos
asteriscos requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to remove the back button, because this view can be accessed from the home view for example. Therefore the back button can be confusing. If we remove it the user can use the breadcrumb to navigate.

image

@yenienserrano
Copy link
Member Author

Back button removed in abd86f2

screencapture-localhost-5601-app-endpoints-summary-2024-11-14-13_44_32

asteriscos
asteriscos approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Chrome 🟢

localhost_5601_app_endpoints-summary

Firefox 🟢

FireShot Capture 017 - Wazuh - localhost

Machi3mfl
Machi3mfl approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Safari

Screen.Recording.2024-11-14.at.1.50.14.PM.mov

Chrome

Screen.Recording.2024-11-14.at.1.49.18.PM.mov

@asteriscos asteriscos merged commit 7ba6643 into 4.10.0 Nov 14, 2024
4 of 5 checks passed
@asteriscos asteriscos deleted the change/7071-redesign-deploy-new-agent-page branch November 14, 2024 16:58
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.94% ( 4445 / 29749 )
Branches 9.8% ( 1887 / 19246 )
Functions 14.71% ( 1057 / 7185 )
Lines 15.15% ( 4339 / 28622 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@chantal-kelm chantal-kelm Awaiting requested review from chantal-kelm

@JuanGarriuz JuanGarriuz Awaiting requested review from JuanGarriuz

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign deploy new agent page
6 participants
@yenienserrano @JuanGarriuz @Desvelao @Machi3mfl @asteriscos @chantal-kelm