Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong color of buttons in dark mode #7153

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Nov 14, 2024

Description

This PR fixes a problem where the buttons in the flyout had the incorrect color in dark mode.
To solve this, a style was added for the dark mode in public/styles/theme/dark/index.dark.scss

Issues Resolved

#7158

Evidence

Before

imagen
imagen

After

imagen
imagen

Test

  • Bring up a Wazuh environment with events or sample data
  • Go to Threat hunting, and open the Events tab
  • In one of the events, click the button Inspect document details at the left. A flyout should open
  • In the flyout, place the cursor above any of the rows. Action buttons should appear at the right. Verify the button colors
  • Test for light and dark mode

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti self-assigned this Nov 14, 2024
guidomodarelli
guidomodarelli previously approved these changes Nov 14, 2024
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫: The test hasn't started yet
🟢: All checks passed.
🟡: There is at least one expected fail or skipped test and no failures.
🔴: There is at least one failed check.
⚪: Doesn't apply

CR 🟢
TEST 🟢

Dark
image

Light
image

@JuanGarriuz JuanGarriuz self-requested a review November 14, 2024 11:25
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.93% ( 4443 / 29756 )
Branches 9.79% ( 1886 / 19255 )
Functions 14.69% ( 1056 / 7186 )
Lines 15.14% ( 4337 / 28628 )

@JuanGarriuz
Copy link
Member

Test

image
image

Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Tostti Tostti merged commit d361538 into 4.10.0 Nov 14, 2024
5 checks passed
@Tostti Tostti deleted the bug/26843-wrong-color-dark-mode-flyout-button branch November 14, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The filter in the flyout is not very visible in dark mode.
3 participants