Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JAVA_HOME to indexer for securityadmin.sh commands #705

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

morph027
Copy link

@morph027 morph027 commented Aug 8, 2022

Signed-off-by: morph027 stefan.heitmueller@gmx.com

alberpilot and others added 26 commits November 24, 2021 17:01
Allow other Exceptions to bubble up a stack trace instead of silently failing in create_user.py
…o-glibc-tomaster

Add fix to avoid GLIBC crash
Signed-off-by: morph027 <stefan.heitmueller@gmx.com>
@teddytpc1 teddytpc1 self-requested a review August 29, 2022 11:08
@teddytpc1
Copy link
Member

teddytpc1 commented Aug 29, 2022

Hi @morph027.
Thanks for your contribution. I have tested the changes and it works fine.
Could you please do the following?

  • Create a new branch from 4.3.
  • Introduce your changes into that new branch.
  • Create a new PR from the new branch to 4.3.

We should merge these changes into 4.3.

@morph027
Copy link
Author

Jip, will do, thanks for the hint!

@teddytpc1
Copy link
Member

Hi @morph027.
Can you open the PR using branch 4.3, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants