Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored and standarized the Python dependencies section for cloud and docker modules #6232

Merged

Conversation

EduLeon12
Copy link
Contributor

@EduLeon12 EduLeon12 commented Jul 11, 2023

Related issue
Closes #6081
Closes wazuh/wazuh#17743

Description

As explained in #6081, Having a Python dependencies section for each cloud and docker-listener module caused an issue because upgrading python version and not updating the documentation in each section caused a dependency issue.

The agent section was changed to have only one Python dependencies section and modules were changed to reference to it.

Checks

  • Compiles without warnings.
  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.
  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

@EduLeon12
Copy link
Contributor Author

Update

For issues caused by master branch renaming, a new branch and PR has been created.

The original branch, PR, and its comments can be found here.

@EduLeon12 EduLeon12 self-assigned this Jul 11, 2023
@EduLeon12 EduLeon12 requested a review from nico-stefani July 11, 2023 16:08
@EduLeon12
Copy link
Contributor Author

Update

After Discussing with the team the upgrade of setuptools package will be done in this PR.

Related Issue:

@EduLeon12 EduLeon12 requested a review from nico-stefani July 12, 2023 15:18
Copy link
Member

@nico-stefani nico-stefani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EduLeon12 EduLeon12 force-pushed the 6081-cloud-container-dependencie-section-refactor branch from e59e778 to d350b9b Compare July 17, 2023 12:22
@EduLeon12 EduLeon12 force-pushed the 6081-cloud-container-dependencie-section-refactor branch from d350b9b to 55b903f Compare August 31, 2023 18:17
@javimed javimed added level/task Task issue type/bug Bug issue labels Sep 1, 2023
@EduLeon12 EduLeon12 requested a review from Selutario September 1, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Archived in project
4 participants