-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored and standarized the Python dependencies section for cloud and docker modules #6232
Merged
nico-stefani
merged 4 commits into
master
from
6081-cloud-container-dependencie-section-refactor
Sep 1, 2023
Merged
Refactored and standarized the Python dependencies section for cloud and docker modules #6232
nico-stefani
merged 4 commits into
master
from
6081-cloud-container-dependencie-section-refactor
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpdateFor issues caused by master branch renaming, a new branch and PR has been created. The original branch, PR, and its comments can be found here. |
nico-stefani
requested changes
Jul 11, 2023
UpdateAfter Discussing with the team the upgrade of setuptools package will be done in this PR. Related Issue: |
6 tasks
nico-stefani
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Selutario
reviewed
Jul 13, 2023
EduLeon12
force-pushed
the
6081-cloud-container-dependencie-section-refactor
branch
from
July 17, 2023 12:22
e59e778
to
d350b9b
Compare
Selutario
suggested changes
Jul 18, 2023
EduLeon12
force-pushed
the
6081-cloud-container-dependencie-section-refactor
branch
from
August 31, 2023 18:17
d350b9b
to
55b903f
Compare
javimed
reviewed
Sep 1, 2023
source/cloud-security/azure/activity-services/prerequisites/dependencies.rst
Outdated
Show resolved
Hide resolved
javimed
approved these changes
Sep 1, 2023
nico-stefani
deleted the
6081-cloud-container-dependencie-section-refactor
branch
September 1, 2023 23:10
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in #6081, Having a Python dependencies section for each cloud and docker-listener module caused an issue because upgrading python version and not updating the documentation in each section caused a dependency issue.
The agent section was changed to have only one Python dependencies section and modules were changed to reference to it.
Checks
code
font for Bash commands, file names, REST paths, and code.redirects.js
script if necessary (check this guide).