Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated plain text auth references for wodles #6405

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

nico-stefani
Copy link
Member

@nico-stefani nico-stefani commented Aug 30, 2023

Description

This PR removes the plain text authentication references for AWS and Azure wodles configurations.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@nico-stefani nico-stefani self-assigned this Aug 30, 2023
@nico-stefani nico-stefani added aws aws wodle documentation azure labels Aug 30, 2023
@nico-stefani nico-stefani linked an issue Aug 30, 2023 that may be closed by this pull request
@GGP1 GGP1 self-requested a review August 31, 2023 18:00
GGP1
GGP1 previously approved these changes Aug 31, 2023
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release type for this issue is patch, in this PR we should only remove the examples since it makes no sense to show examples of something that we do not recommend using.

Removing all mentions to credentials in configuration could be done in a different PR in the future.

Edit: take a look at #6405 (comment)

@nico-stefani nico-stefani force-pushed the 6363-remove-deprecated-plain-text-auth branch from 34a0229 to 2b22126 Compare February 20, 2024 13:38
@nico-stefani nico-stefani changed the base branch from 5.0 to master February 20, 2024 13:38
@nico-stefani nico-stefani requested a review from GGP1 February 21, 2024 13:18
@nico-stefani nico-stefani force-pushed the 6363-remove-deprecated-plain-text-auth branch from 845520a to 390c4fc Compare February 21, 2024 14:09
GGP1
GGP1 previously approved these changes Feb 21, 2024
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Selutario
Selutario previously approved these changes Feb 26, 2024
@nico-stefani nico-stefani dismissed stale reviews from Selutario and GGP1 via 53aba01 February 28, 2024 12:38
Co-authored-by: Javier Medeot <javier.medeot@wazuh.com>
@nico-stefani nico-stefani requested a review from javimed February 28, 2024 12:39
Copy link
Member

@javimed javimed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javimed javimed merged commit 1488b1c into master Feb 29, 2024
3 checks passed
@javimed javimed deleted the 6363-remove-deprecated-plain-text-auth branch February 29, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws aws wodle documentation azure level/task Task issue type/maintenance
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove deprecated plain text authentication method from AWS and Azure
4 participants