-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GCP wodle options descriptions #6570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add tables like the ones that the aws-s3 module has to summarize the available options and if they are mandatory or not (e.g. the one for the bucket's options).
Also, we should check if these changes will be part of release 4.6.0
or not.
fce26ef
to
307d94b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@GGP1 what if we made changes to get the result in the image below? Look into the content and the right sidebar as well. You'll see further changes in structure and an additional table for the attributes and the clarification |
@javimed that looks better in my opinion. Feel free to commit the changes you consider necessary. |
Ok, I added a few changes. Let me know if it's ok and if we're good to merge this PR, @Selutario @fdalmaup |
Description
Closes #5699.
Improves the GCP wodle gcp-bucket and gcp-pubsub configuration options descriptions.
Checks
Docs building
build
Code formatting and web optimization
redirects.js
script if necessary (check this guide).Writing style
code
font for Bash commands, file names, REST paths, and code.