-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove launchtl unload step from macOS uninstalling manual #7123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
332ab03
to
4f03394
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGtm, unless we want it live in production now as a 4.7 hotfix which is perfectly valid for the case of our documentation. This would require changng base branch to 4.7
.
@javimed this change applies for version 4.8.0 onwards, that's why the base change we made later, this is the PR where the change is included only in 4.8.0. |
Description
The macOS uninstalling manual page was modified given the
launchtl unload
command might throw an error if the service has not yet been loaded.In this case, we choose to delete such a step. Given this, after removing the Wazuh agent, if the service is loaded, it will continue to be listed until the system is restarted or the service is manually unloaded.
Checks
Docs building
Code formatting and web optimization
redirects.js
script if necessary (check this guide).Writing style
code
font for Bash commands, file names, REST paths, and code.