Fix init.d file installation for Alma Linux and Rocky Linux #2053

verdx · 2023-01-19T18:21:25Z

Related issue
#1626

Description

In this PR we propose a fix to the matter of enabling Wazuh service in RHEL 9 derived systems:

Alma Linux 9
Rocky Linux 9

Logs example

Error:

# systemctl enable wazuh-agent
Synchronizing state of wazuh-agent.service with SysV service script with /usr/lib/systemd/systemd-sysv-install.
Executing: /usr/lib/systemd/systemd-sysv-install enable wazuh-agent
Failed to execute /usr/lib/systemd/systemd-sysv-install: No such file or directory

Fixed:

# systemctl enable wazuh-agent
Created symlink /etc/systemd/system/multi-user.target.wants/wazuh-agent.service → /usr/lib/systemd/system/wazuh-agent.service.

Tests

Tests for Linux RPM
- Build the package for x86_64

RHEL 9

Agent
- Install
- Upgrade
- Remove
- Systemctl enable
- Systemctl disable
- Systemctl start
- Systemctl stop
- Systemctl restart
Manager
- Install
- Upgrade
- Remove
- Systemctl enable
- Systemctl disable
- Systemctl start
- Systemctl stop
- Systemctl restart

Rocky Linux 9

Alma Linux 9

Oracle Linux 9

CentOS 7

Agent
- Install
- Upgrade
- Remove
- Systemctl enable
- Systemctl disable
- Systemctl start
- Systemctl stop
- Systemctl restart
Manager
- Install
- Upgrade
- Remove
- Systemctl enable
- Systemctl disable
- Systemctl start
- Systemctl stop
- Systemctl restart

…or RHEL 9 Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

davidcr01

LGTM

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx · 2023-01-20T13:26:55Z

In addition to the fix changed in this PR, a test is being added to Github Actions to check for this error from now onwards. Even though other systemctl commands cannot be used inside a docker container, systemctl enable does work as expected.

Tests

Alma Linux 9

> sudo docker run --privileged -it almalinux:9.1 bash
[root@97a20a2d6415 /]# curl https://packages-dev.wazuh.com/pre-release/yum/wazuh-agent-4.4.0-1.x86_64.rpm -O -J && yum install -y wazuh-agent-4.4.0-1.x86_64.rpm
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 8743k  100 8743k    0     0  4788k      0  0:00:01  0:00:01 --:--:-- 4785k
AlmaLinux 9 - AppStream                                                                                                                                                            4.0 MB/s | 7.1 MB     00:01    
AlmaLinux 9 - BaseOS                                                                                                                                                               2.1 MB/s | 2.0 MB     00:00    
AlmaLinux 9 - Extras                                                                                                                                                                19 kB/s |  17 kB     00:00    
Dependencies resolved.
===================================================================================================================================================================================================================
 Package                                                  Architecture                                Version                                              Repository                                         Size
===================================================================================================================================================================================================================
Installing:
 wazuh-agent                                              x86_64                                      4.4.0-1                                              @commandline                                      8.5 M
Installing dependencies:
 initscripts-service                                      noarch                                      10.11.5-1.el9                                        baseos                                             13 k

Transaction Summary
===================================================================================================================================================================================================================
Install  2 Packages

Total size: 8.6 M
Total download size: 13 k
Installed size: 25 M
Downloading Packages:
initscripts-service-10.11.5-1.el9.noarch.rpm                                                                                                                                       221 kB/s |  13 kB     00:00    
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total                                                                                                                                                                               22 kB/s |  13 kB     00:00     
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                                                                           1/1 
  Installing       : initscripts-service-10.11.5-1.el9.noarch                                                                                                                                                  1/2 
  Running scriptlet: wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
  Installing       : wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
  Running scriptlet: wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
  Verifying        : initscripts-service-10.11.5-1.el9.noarch                                                                                                                                                  1/2 
  Verifying        : wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 

Installed:
  initscripts-service-10.11.5-1.el9.noarch                                                                        wazuh-agent-4.4.0-1.x86_64                                                                       

Complete!
[root@97a20a2d6415 /]# systemctl enable wazuh-agent
Synchronizing state of wazuh-agent.service with SysV service script with /usr/lib/systemd/systemd-sysv-install.
Executing: /usr/lib/systemd/systemd-sysv-install enable wazuh-agent
Failed to execute /usr/lib/systemd/systemd-sysv-install: No such file or directory
[root@97a20a2d6415 /]# exit
exit

Red Hat Enterprise Linux 9

>sudo docker run --privileged -it redhat/ubi9 bash
[root@c50fd29636a4 /]# curl https://packages-dev.wazuh.com/pre-release/yum/wazuh-agent-4.4.0-1.x86_64.rpm -O -J && yum install -y wazuh-agent-4.4.0-1.x86_64.rpm
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 8743k  100 8743k    0     0  5495k      0  0:00:01  0:00:01 --:--:-- 5495k
Updating Subscription Management repositories.
Unable to read consumer identity
Subscription Manager is operating in container mode.

This system is not registered with an entitlement server. You can use subscription-manager to register.

Red Hat Universal Base Image 9 (RPMs) - BaseOS                                                                                                                                     261 kB/s | 577 kB     00:02    
Red Hat Universal Base Image 9 (RPMs) - AppStream                                                                                                                                  824 kB/s | 1.7 MB     00:02    
Red Hat Universal Base Image 9 (RPMs) - CodeReady Builder                                                                                                                           48 kB/s | 102 kB     00:02    
Dependencies resolved.
===================================================================================================================================================================================================================
 Package                                                 Architecture                               Version                                            Repository                                             Size
===================================================================================================================================================================================================================
Installing:
 wazuh-agent                                             x86_64                                     4.4.0-1                                            @commandline                                          8.5 M
Installing dependencies:
 initscripts-service                                     noarch                                     10.11.5-1.el9                                      ubi-9-baseos-rpms                                      15 k

Transaction Summary
===================================================================================================================================================================================================================
Install  2 Packages

Total size: 8.6 M
Total download size: 15 k
Installed size: 25 M
Downloading Packages:
initscripts-service-10.11.5-1.el9.noarch.rpm                                                                                                                                        95 kB/s |  15 kB     00:00    
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total                                                                                                                                                                               94 kB/s |  15 kB     00:00     
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                                                                           1/1 
  Installing       : initscripts-service-10.11.5-1.el9.noarch                                                                                                                                                  1/2 
  Running scriptlet: wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
  Installing       : wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
  Running scriptlet: wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
  Verifying        : initscripts-service-10.11.5-1.el9.noarch                                                                                                                                                  1/2 
  Verifying        : wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
Installed products updated.

Installed:
  initscripts-service-10.11.5-1.el9.noarch                                                                        wazuh-agent-4.4.0-1.x86_64                                                                       

Complete!
[root@c50fd29636a4 /]# systemctl enable wazuh-agent
Created symlink /etc/systemd/system/multi-user.target.wants/wazuh-agent.service → /usr/lib/systemd/system/wazuh-agent.service.
[root@c50fd29636a4 /]#

Rocky Linux 9

sudo docker run --privileged -it rockylinux:9 bash
[root@684eb3080b47 /]# curl https://packages-dev.wazuh.com/pre-release/yum/wazuh-agent-4.4.0-1.x86_64.rpm -O -J && yum install -y wazuh-agent-4.4.0-1.x86_64.rpm
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 8743k  100 8743k    0     0  4788k      0  0:00:01  0:00:01 --:--:-- 4785k
Rocky Linux 9 - BaseOS                                                                                                                                                             637 kB/s | 1.7 MB     00:02    
Rocky Linux 9 - AppStream                                                                                                                                                          2.1 MB/s | 6.4 MB     00:03    
Rocky Linux 9 - Extras                                                                                                                                                              24 kB/s | 8.5 kB     00:00    
Dependencies resolved.
===================================================================================================================================================================================================================
 Package                                                  Architecture                                Version                                              Repository                                         Size
===================================================================================================================================================================================================================
Installing:
 wazuh-agent                                              x86_64                                      4.4.0-1                                              @commandline                                      8.5 M
Installing dependencies:
 initscripts-service                                      noarch                                      10.11.5-1.el9                                        baseos                                             13 k

Transaction Summary
===================================================================================================================================================================================================================
Install  2 Packages

Total size: 8.6 M
Total download size: 13 k
Installed size: 25 M
Downloading Packages:
initscripts-service-10.11.5-1.el9.noarch.rpm                                                                                                                                        89 kB/s |  13 kB     00:00    
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total                                                                                                                                                                               30 kB/s |  13 kB     00:00     
Rocky Linux 9 - BaseOS                                                                                                                                                             151 kB/s | 1.7 kB     00:00    
Importing GPG key 0x350D275D:
 Userid     : "Rocky Enterprise Software Foundation - Release key 2022 <releng@rockylinux.org>"
 Fingerprint: 21CB 256A E16F C54C 6E65 2949 702D 426D 350D 275D
 From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-Rocky-9
Key imported successfully
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                                                                           1/1 
  Installing       : initscripts-service-10.11.5-1.el9.noarch                                                                                                                                                  1/2 
  Running scriptlet: wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
  Installing       : wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
  Running scriptlet: wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 
  Verifying        : initscripts-service-10.11.5-1.el9.noarch                                                                                                                                                  1/2 
  Verifying        : wazuh-agent-4.4.0-1.x86_64                                                                                                                                                                2/2 

Installed:
  initscripts-service-10.11.5-1.el9.noarch                                                                        wazuh-agent-4.4.0-1.x86_64                                                                       

Complete!
[root@684eb3080b47 /]# systemctl enable wazuh-agent
Synchronizing state of wazuh-agent.service with SysV service script with /usr/lib/systemd/systemd-sysv-install.
Executing: /usr/lib/systemd/systemd-sysv-install enable wazuh-agent
Failed to execute /usr/lib/systemd/systemd-sysv-install: No such file or directory
[root@684eb3080b47 /]#

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

alberpilot · 2023-01-24T08:36:38Z

.github/workflows/test-enable-alma9-agent.yml

@@ -0,0 +1,28 @@
+name: Test the enabling of the Wazuh agent - AlmaLinux 9 - RPM


Could we define an array of RPM manager-supported operating systems and loop into it? And another one for the agent? Could you please add all manager-supported RPM operating systems?
In addition, it could be great if we test Debian too.

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx · 2023-02-02T10:06:57Z

GitHub Actions Update

The first action used, https://github.com/marketplace/actions/wait-for-check, has a problem, as it searches for the check to wait for using the name of a job. It works correctly but, when using matrices, the name of the check is changed and the elements of the matrix used for a run are added. That way, to look for the name one would have to look for every option possible in the matrix, which would take out the utility of the matrix, that elements can be added or removed easily.
A different waiting action has been tested, https://github.com/ArcticLampyrid/action-wait-for-workflow, that looks for the workflow by the file name. This has worked correctly, as seen in these action runs:

DFolchA · 2023-02-02T15:29:53Z

rpms/SPECS/wazuh-manager.spec

@@ -332,7 +332,7 @@ fi

 if [ -f /etc/os-release ]; then
  source /etc/os-release
-  if [ "${NAME}" = "Red Hat Enterprise Linux" ] && [ "$((${VERSION_ID:0:1}))" -ge 9 ]; then
+  if ( [ "${NAME}" = "Red Hat Enterprise Linux" ] || [ "${NAME}" = "Rocky Linux" ] || [ "${NAME}" = "AlmaLinux" ] ) && [ "$((${VERSION_ID:0:1}))" -ge 9 ]; then


This should also cover the corespondent versions of CentOS and Fedora, if possible we should use a generic command to determine these systems.

The generic command would be useful but the only common variable in /etc/os-release is ID_LIKE, which function is this type of things. The problem is it is also the same for Oracle Linux 9, which doesn't have this problem.

CentOS 9 Stream and Fedora 34 added in 08bd107

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

davidcr01 · 2023-02-03T11:34:00Z

.github/actions/test-install-enable/install_and_enable.sh

+    apt-get update
+    apt-get install -y systemd
+else
+    common_logger -e "Couldn'd find type of system"


Please change Couldn'd to Couldn't.

Done in 24734fb

davidcr01

https://github.com/wazuh/wazuh-packages/pull/2053/files#r1095703906

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

DFolchA

LGTM

alberpilot

Please review the comments

macos/generate_wazuh_packages.sh

.github/workflows/upload-deb-images.yml

.github/workflows/upload-rpm-images.yml

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

alberpilot

LGTM

…-services

DFolchA

LGTM

Add Alma Linux, Rocky Linux and Oracle Linux to the init.d fix done f…

dd6ee39

…or RHEL 9 Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx self-assigned this Jan 19, 2023

verdx requested review from DFolchA and removed request for DFolchA January 19, 2023 18:21

verdx added type: bug component: agent/rpm component: manager/rpm labels Jan 19, 2023

verdx linked an issue Jan 19, 2023 that may be closed by this pull request

Investigate RHEL9 service installation error #1626

Closed

Remove Oracle Linux as it does not replicate the error

1312148

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx changed the title ~~Fix init.d file installation for Alma Linux, Rocky Linux and Oracle Linux~~ Fix init.d file installation for Alma Linux and Rocky Linux Jan 20, 2023

Fix Red Hat Enterprise Linux repeated and Alma Linux missing

226f331

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx requested review from DFolchA, alberpilot and davidcr01 January 20, 2023 10:44

DFolchA previously approved these changes Jan 20, 2023

View reviewed changes

alberpilot approved these changes Jan 20, 2023

View reviewed changes

davidcr01 previously approved these changes Jan 20, 2023

View reviewed changes

verdx added 2 commits January 20, 2023 13:10

Add Github Actions test for systemctl in RHEL 9 and derivatives

756ae34

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Change names and Pull request paths

1bd2583

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx added 5 commits January 20, 2023 14:50

Change images and fix script for github actions

de8edfc

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Small fix

742b4a1

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Fix paths in workflows for github actions

9ef7f71

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Fix call to generate_rpm_package in github actions

d947c57

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Fix test path in shared file with docker

8d49c5a

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx force-pushed the 1626-fix-rhel9-derived-services branch from 8c71106 to 8d49c5a Compare January 23, 2023 12:27

verdx added 2 commits January 23, 2023 13:29

Merge branch 'master' into 1626-fix-rhel9-derived-services

83ee9ab

Fixes to github actions tests

163d3b6

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

alberpilot suggested changes Jan 24, 2023

View reviewed changes

Add workflow to create rpm packages for all architectures

ef4db24

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx added 2 commits February 2, 2023 10:33

Fix download artifact from success workflow

8c9d4ef

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Change waiting action for deb too

2bd2bc0

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

DFolchA suggested changes Feb 2, 2023

View reviewed changes

verdx added 2 commits February 2, 2023 17:07

Added CentOS 9 Stream and Fedora 34 to the orifinal fix

08bd107

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Add install and enable test for fedora 34

f52d16b

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx mentioned this pull request Feb 2, 2023

Investigate RHEL9 service installation error #1626

Closed

verdx requested a review from DFolchA February 2, 2023 16:11

davidcr01 reviewed Feb 3, 2023

View reviewed changes

davidcr01 suggested changes Feb 3, 2023

View reviewed changes

Fix typo

24734fb

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

verdx requested a review from davidcr01 February 3, 2023 12:08

DFolchA approved these changes Feb 3, 2023

View reviewed changes

alberpilot suggested changes Feb 3, 2023

View reviewed changes

verdx added 6 commits February 3, 2023 16:54

Only create the correspondent docker image

ad78e4b

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Add the changes to build_packages and fix in upload images

2ae6fd4

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Add changes to test install

5679018

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Missing parenthesis

908ef35

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Change how the conditionals are called in the test install files

39ea44e

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

Missing parenthesis

b51b449

Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>

alberpilot requested review from DFolchA and alberpilot February 6, 2023 09:56

alberpilot approved these changes Feb 6, 2023

View reviewed changes

davidcr01 approved these changes Feb 6, 2023

View reviewed changes

Merge remote-tracking branch 'origin/4.5' into 1626-fix-rhel9-derived…

c1fcff4

…-services

DFolchA approved these changes Feb 6, 2023

View reviewed changes

DFolchA merged commit ccb2072 into 4.5 Feb 6, 2023

DFolchA deleted the 1626-fix-rhel9-derived-services branch February 6, 2023 15:46

vikman90 added type/bug Bug issue and removed type: bug labels Jun 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix init.d file installation for Alma Linux and Rocky Linux #2053

Fix init.d file installation for Alma Linux and Rocky Linux #2053

verdx commented Jan 19, 2023 •

edited

Loading

davidcr01 left a comment

verdx commented Jan 20, 2023 •

edited

Loading

alberpilot Jan 24, 2023

verdx commented Feb 2, 2023

DFolchA Feb 2, 2023

verdx Feb 2, 2023

verdx Feb 2, 2023

davidcr01 Feb 3, 2023

verdx Feb 3, 2023

davidcr01 left a comment

DFolchA left a comment

alberpilot left a comment

alberpilot left a comment

DFolchA left a comment

		@@ -0,0 +1,28 @@
		name: Test the enabling of the Wazuh agent - AlmaLinux 9 - RPM

Fix init.d file installation for Alma Linux and Rocky Linux #2053

Fix init.d file installation for Alma Linux and Rocky Linux #2053

Conversation

verdx commented Jan 19, 2023 • edited Loading

Description

Logs example

Tests

RHEL 9

Rocky Linux 9

Alma Linux 9

Oracle Linux 9

CentOS 7

davidcr01 left a comment

Choose a reason for hiding this comment

verdx commented Jan 20, 2023 • edited Loading

Tests

alberpilot Jan 24, 2023

Choose a reason for hiding this comment

verdx commented Feb 2, 2023

GitHub Actions Update

DFolchA Feb 2, 2023

Choose a reason for hiding this comment

verdx Feb 2, 2023

Choose a reason for hiding this comment

verdx Feb 2, 2023

Choose a reason for hiding this comment

davidcr01 Feb 3, 2023

Choose a reason for hiding this comment

verdx Feb 3, 2023

Choose a reason for hiding this comment

davidcr01 left a comment

Choose a reason for hiding this comment

DFolchA left a comment

Choose a reason for hiding this comment

alberpilot left a comment

Choose a reason for hiding this comment

alberpilot left a comment

Choose a reason for hiding this comment

DFolchA left a comment

Choose a reason for hiding this comment

verdx commented Jan 19, 2023 •

edited

Loading

verdx commented Jan 20, 2023 •

edited

Loading