Rework of FIM integration/system tests due to new synchronization mechanism #1915

JoseAntonioMHerrera · 2021-09-22T08:30:11Z

Due to the implementation of rsync as the new engine for FIM db synchronization the following tests need to be reworked to adapt to the new sync messages coming from rsync.

Test synchronization

test_registry_responses_win32.py
test_response_timeout.py
test_sync_disabled_win32.py

All the above tests look for synchronization events messages that now will be deleted.

Test files

test_max_eps_synchronization.py

The above test assesses the max sync events per second defined in syscheck configuration for the synchronization process.

Test limits

The new design implies that the DB limits are now separated in:

Limit for the number of entries in the files table
Limit for the number of entries in the registry table

The following tests would be affected by the changes introduced at wazuh/wazuh#10224:

/wazuh-qa/tests/integration/test_fim# find . -name "*limit*"
./test_registry/test_registry_file_limit
./test_registry/test_registry_file_limit/test_registry_limit_values.py
./test_registry/test_registry_file_limit/test_registry_limit_capacity_alerts.py
./test_registry/test_registry_file_limit/test_registry_limit_full.py
./test_registry/test_registry_report_changes/test_registry_diff_size_limit_values.py
./test_registry/test_registry_report_changes/test_registry_all_limits_disabled.py
./test_registry/test_registry_report_changes/data/wazuh_registry_report_changes_limits_quota.yaml
./test_files/test_report_changes/test_diff_size_limit_configured.py
./test_files/test_report_changes/test_diff_size_limit_default.py
./test_files/test_file_limit
./test_files/test_file_limit/test_file_limit_values.py
./test_files/test_file_limit/test_file_limit_no_limit.py
./test_files/test_file_limit/test_file_limit_full.py
./test_files/test_file_limit/test_file_limit_default.py
./test_files/test_file_limit/test_file_limit_delete_full.py
./test_files/test_file_limit/test_file_limit_capacity_alerts.py

The text was updated successfully, but these errors were encountered:

damarisg · 2021-12-13T11:57:22Z

During Sprint 2, the tests were analyzed and it was decided to create sub-issues because being a TDD job this would take more than one Sprint and it is necessary to carry out the analysis of the entire process.

damarisg · 2022-04-20T18:21:54Z

Each change is located on 1915-fim-rsync-new-synchronization-mechanism

damarisg · 2022-10-26T18:00:55Z

In addition, this issue contains the new changes applied by 3036

Deblintrake09 · 2022-11-30T11:30:50Z

Update 2022/11/28

Start fixing conflicts with master
Fix failing tests

Update 2022/11/29

Continue fixing tests style and spacing
Debug test_registry_responses_win32.py that fails but expected message is read in logs.
Asked Core for Rebase because of report_changes fixes merged cause tests to fail

Deblintrake09 · 2023-01-26T20:29:04Z

Update 26/01/2023

Generate packages
Fix conflicts with master

Deblintrake09 · 2023-01-27T18:50:18Z

Update 27/01/2023

Debug failing IT test_restrict_valid
Found possible Bug on branch on Windows
Running Windows master instance to validate.

Deblintrake09 · 2023-01-30T20:34:01Z

Update 30/01/2023

Finish fixing test_restrict_valid
Launched Jenkins instances

This reverts commit bbedbc9, reversing changes made to 469828c.

* fix: Changes log messages and organize variables * fix: import variables * add: delete conf deprecated * fix: Order of messages * add: spaces recommended * rm: conf deprecated * rm: logs deprecated * rf: fix messages and callbacks * rf: remove hardcoded marks * fix: log message to Windows * rf: add test to validate registry key limit * rf: test_registry_limit_full for registry values * add: new test_registry_key_limit_values * rm: unused lines * rf: test_registry_limit_values - update docu * rf: test_registry_limit_capacity_alerts - fix docu * rf: test_registr_limit_values - fix documentation * rf: test_registry_value_limit_full - fix docu * rf: test_registry_key_limit_full - fix docu * rf: fix format of key_limit_full * rf: fix syscheck_event_windows.json * rm: Skip fixed * rm: variables name to DB. * add: variable error and archives.log to Windows. * Change owner to root * Fx:Update msg to detect that fim scan was finish * add: Migration of methods. * fix: Change messages- Remove skips- Change field name of events. * skíp: Tier 2 has to refactor required. * fix: Change log messages - Remove a callback. * fix: Add file created to check events. * fix: Check fim_registry event component not exists. * add: Check that Audit is started when working with whodata. * fix: Check files created - Add callback of sync initial scan - Remove spaces. * fix: Check asserts - Remove duplicates variables * fix test_sync_max_eps for scheduled mode * add: new test_sync_max_eps for realtime/whodata * rf: extract common functions and messages * rf: update wazuh_conf and remove invalid test * rf: fix test_max_eps.py * rf: fix wait_for_fim_start_function * rf: fix test_max_eps for realtime file events * rf: fix callback * Fx: Apply Pycodestyle * rf: fix callback an fim_local_internal_options * rf: fix codestyle to adhere to pep8 * rf: added whodata cases for test_max_eps * rf: fix whodata callback for windows * rf: skipped test because of jenkins behaviour * Apply suggestions from code review Co-authored-by: Cami Romero <37776796+CamiRomero@users.noreply.github.com> * rf: fix variables name in functions * rf: fix find_value_in_list function * rf: fix pycodestyle * rf: remove hardcoded timeouts * rf: remove skip to test on Jenkins * refac: disable unneeded fim modules * fix: fix indentation * test: skip test_registry_responses_win3 * fix: modify config yml file * rf: extracted error messages * fix: added local_internal_options, extracted error messages and fixed key creation * style: fix to adhere to pep8 * fix: Fix timeout * rm: remove unnecesary section in test cases * style: Fix spacing and line lenght * fix: Modify CB_REGISTRY_DBSYNC_NO_DATA * fix: Path check in find_value_in_event_list * fix: Callbacks to detect fim_registry_key/value * fix: update imports to module.fim.utils * rm: Delete unused file fim_synchronization.py * add: registry_integrity_event callbacks * fix: event detection in test_sync_enabled_win32 * fix: Callback get registry_key or registry_value * style: removed whitespaces * style: Modify comments and Documentation Co-authored-by: Dámaris <seyla.gomez@wazuh.com> * style: rename variable * rm: Delete unused functions * rm: Delete duplicated fixture * fix: Add deleted _create_regular functions * fix import errors * fix: Callback CB_INODE_ENTRIES_PATH_COUNT * fix(#3036): fix file_limit configs * docu(#3036): update tests min version * fix(#3036): fix test_registry_limit configs * docu(#3036): fix min_version * fix(#3036): CB registry_key_limit_full * fix(#3036): fix test_file_limit_no_limit callback * fix(#3036): add local_internal_options to tests * fix(#3036): test_registry_key_full cb and key * feat(#3053): add callbacks to fim.event_monitor * feat(#3053): add fixtures to fim conftest * feat(#3053): add test_sync_overlap test skeleton * refactor(#3053): move CBs to fim.event_monitor * fix(#3053): add new case to test_sync_overlap * fix(#3053): fix truncate_monitored_files fixture * feat(#3053): add create_files_in_folder fixture * docu(#3053): fix test_sync_interval docu and style * style(#3053): fix blank lines in conftest.py * docu(#3053): update changelog.md * style(#3053): fix spacing and indentations * style(#3053): update spacing and indentation * fix(#3053): fix config format to work on macOS * fix(#3053): fix config format to work on macOS * fix(#3053): update spacing in configuration * fix(#3053): remove unnecesary list conversion * refactor(#3036): move CB and import to modules.fim * docs(#3036): add fixture documentation in tests * fix(#3036): update config with correct values * style(#3036): fix spacing in yaml conf files * fix(#3036): fix config yaml spacing * style(#3036): fix style and indentations * fix(#3036): fix wazuh_conf.yaml spacing * docs(#3036): update changelog.md * fix(#3053): fix and add cases test_sync_overlap * refactor(#3053): extract variables and callbacks * docs(#3053): update changelog.md * style(#3053): fix spacing * fix(#3053): add monitored_dir parameter to test * fix(#3053): fix invalid max_interval value test * fix(#3036): increase test_max_eps created files * docu(#3053): update event_monitor documentation * docu(#3053): fix fim.event_monitor docu * refactor(#3036): cleaned up callbacks * style(#3036): removed trailing whitespace * feat(#3053): add new callbacks * feat(#3053): new test_sync_time module * fix(#3053): remove unused callbacks * docu(#3053): update test_sync_time docu * style(#3053): fix test_sync_time spacing * style(#3053): fix test_sync_time spacing * docu(#3036): update chengelog.md * docs(#3053): update tests documentation * style(#3053): remove whitespaces * docs(#3053): added comments and docu * style(#3053): fixed indentation issue * refactor(#1915): refactor fim framework * fix(#1915): fix imports * style(#1915): fix spacing and indentations * fix(#1915): add missing fixture * style(#1915): fix spacing in yaml files * fix(#1915): fix callbacks and fixture import * refactor(#1915): move callbacks to event_monitor * refactor(#1915): update callback imports * style(#1915): fix indentation and spacing * feat(#1915): update callbacks and functions * refactor(#1915): update imports from fim framework * fix(#1915): fix regular_file_cud function * fix(#1915): fix delete_file usage instances * fix(#1915): fix test_max_eps * style(#1915): fix indentation and whitespaces * fix(#1915): skip test_max_eps module * fix(#1915): replace removed fixture * fix(#1915): fix test_synchronize_integrity conf * fix(#1915): fix test_restrict_valid scheduled mode * style(#1915): fix test_restrict_valid conf spacing * style(#1915): remove confs redundant quotes * fix(#1915): fix test_restrict_valid cases * fix(#1915): fix windows test cases * chore: bump version to 4.6 * fix(#1915): revert merge 'master' into dev branch" This reverts commit bbedbc9, reversing changes made to 469828c. * fix(#1915): remove duplicated fixture * fix(#1915): add delay for difffolder deletion * style(#1915): fix whitespaces and file names * fix(#1915): remove redundant vars and functions * style(#1915): improve documentation * fix(#1915): extract duplicated function * docs(#1915): improve documentation * fix(#1915): remove unneeded file * chore(#1915): remove unused imports --------- Co-authored-by: Deblintrake09 <amicalizzi2005@gmail.com> Co-authored-by: camila <camiromero100@gmail.com> Co-authored-by: Cami Romero <37776796+CamiRomero@users.noreply.github.com> Co-authored-by: jmv74211 <jmv74211@gmail.com>

chemamartinez added feature/fim test/integration refactor Redesign and implement an existing development/feature labels Sep 22, 2021

damarisg added subteam/qa-storm labels Nov 26, 2021

CamiRomero self-assigned this Dec 7, 2021

damarisg added the Epic label Dec 10, 2021

damarisg mentioned this issue Mar 28, 2022

FIM RSync as a new synchronization mechanism - Fix tests #2728

Merged

8 tasks

damarisg changed the title ~~Rework of FIM integration tests due to new synchronization mechanism~~ Rework of FIM integration/system tests due to new synchronization mechanism Apr 20, 2022

damarisg assigned damarisg and Deblintrake09 Jun 4, 2022

damarisg added this to the Core PRs approval - 4.5.0 milestone Sep 8, 2022

Deblintrake09 linked a pull request Sep 8, 2022 that will close this issue

FIM RSync as a new synchronization mechanism - Fix tests #2728

Merged

8 tasks

damarisg added the subteam/qa-rainbow label Sep 8, 2022

Deblintrake09 mentioned this issue Sep 13, 2022

QA Planning: Replace FIM DB implementation with dbsync and rsync #3242

Closed

3 tasks

damarisg unassigned damarisg and CamiRomero Nov 15, 2022

Deblintrake09 added a commit that referenced this issue Nov 28, 2022

refactor(#1915): merge master - fix conflics

b0f831b

Deblintrake09 added a commit that referenced this issue Nov 28, 2022

refactor(#1915): refactor fim framework

e9df6ba

Deblintrake09 added a commit that referenced this issue Nov 28, 2022

fix(#1915): fix imports

05d3634

Deblintrake09 added a commit that referenced this issue Nov 29, 2022

style(#1915): fix spacing and indentations

61e0dfd

Deblintrake09 added a commit that referenced this issue Nov 30, 2022

fix(#1915): add missing fixture

48d6f53

Deblintrake09 added a commit that referenced this issue Nov 30, 2022

style(#1915): fix spacing in yaml files

5bd0df6

Deblintrake09 added a commit that referenced this issue Nov 30, 2022

fix(#1915): fix callbacks and fixture import

39c99d2

Deblintrake09 added a commit that referenced this issue Dec 1, 2022

refactor(#1915): move callbacks to event_monitor

67b32d5

Deblintrake09 added a commit that referenced this issue Dec 1, 2022

refactor(#1915): update callback imports

67d982c

Deblintrake09 added a commit that referenced this issue Jan 26, 2023

merge(#1915): 'master' into dev branch

e6652b2

Deblintrake09 added a commit that referenced this issue Jan 26, 2023

fix(#1915): replace removed fixture

73233f4

Deblintrake09 added a commit that referenced this issue Jan 27, 2023

fix(#1915): fix test_synchronize_integrity conf

c362a8b

Deblintrake09 added a commit that referenced this issue Jan 27, 2023

merge(#1915): merge master into branch

d671b56

Deblintrake09 added a commit that referenced this issue Jan 30, 2023

fix(#1915): fix test_restrict_valid scheduled mode

d6f560f

Deblintrake09 added a commit that referenced this issue Jan 30, 2023

style(#1915): fix test_restrict_valid conf spacing

caecd65

Deblintrake09 added a commit that referenced this issue Jan 30, 2023

style(#1915): remove confs redundant quotes

99cfcf0

Deblintrake09 added a commit that referenced this issue Jan 30, 2023

fix(#1915): fix test_restrict_valid cases

eaaa642

Deblintrake09 added a commit that referenced this issue Jan 31, 2023

fix(#1915): fix windows test cases

469828c

Deblintrake09 added a commit that referenced this issue Feb 6, 2023

merge(#1915): 'master' into dev branch

bbedbc9

Deblintrake09 added a commit that referenced this issue Feb 6, 2023

fix(#1915): revert merge 'master' into dev branch"

5e0240d

This reverts commit bbedbc9, reversing changes made to 469828c.

Deblintrake09 added a commit that referenced this issue Feb 6, 2023

merge(#1915): '4.5' into 'dev branch'

7c41de2

Deblintrake09 added a commit that referenced this issue Feb 6, 2023

fix(#1915): remove duplicated fixture

b1d6703

Deblintrake09 added a commit that referenced this issue Feb 7, 2023

fix(#1915): add delay for difffolder deletion

183ffa6

Deblintrake09 added a commit that referenced this issue Feb 7, 2023

style(#1915): fix whitespaces and file names

87fad43

Deblintrake09 added a commit that referenced this issue Feb 9, 2023

fix(#1915): remove redundant vars and functions

a7b5653

Deblintrake09 added a commit that referenced this issue Feb 9, 2023

style(#1915): improve documentation

aa1c50c

Deblintrake09 added a commit that referenced this issue Feb 9, 2023

fix(#1915): extract duplicated function

2cb2b0f

Deblintrake09 added a commit that referenced this issue Feb 9, 2023

docs(#1915): improve documentation

d211506

Deblintrake09 added a commit that referenced this issue Feb 9, 2023

merge(#1915): '4.5' into dev branch

876c3b0

Deblintrake09 added a commit that referenced this issue Feb 9, 2023

fix(#1915): remove unneeded file

37e3e0d

jmv74211 added a commit that referenced this issue Feb 15, 2023

chore(#1915): remove unused imports

60e814b

jmv74211 closed this as completed Feb 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework of FIM integration/system tests due to new synchronization mechanism #1915

Rework of FIM integration/system tests due to new synchronization mechanism #1915

JoseAntonioMHerrera commented Sep 22, 2021 •

edited by chemamartinez

Loading

damarisg commented Dec 13, 2021

damarisg commented Apr 20, 2022

damarisg commented Oct 26, 2022

Deblintrake09 commented Nov 30, 2022 •

edited

Loading

Deblintrake09 commented Jan 26, 2023

Deblintrake09 commented Jan 27, 2023

Deblintrake09 commented Jan 30, 2023

Rework of FIM integration/system tests due to new synchronization mechanism #1915

Rework of FIM integration/system tests due to new synchronization mechanism #1915

Comments

JoseAntonioMHerrera commented Sep 22, 2021 • edited by chemamartinez Loading

Test synchronization

Test files

Test limits

damarisg commented Dec 13, 2021

damarisg commented Apr 20, 2022

damarisg commented Oct 26, 2022

Deblintrake09 commented Nov 30, 2022 • edited Loading

Update 2022/11/28

Update 2022/11/29

Deblintrake09 commented Jan 26, 2023

Update 26/01/2023

Deblintrake09 commented Jan 27, 2023

Update 27/01/2023

Deblintrake09 commented Jan 30, 2023

Update 30/01/2023

JoseAntonioMHerrera commented Sep 22, 2021 •

edited by chemamartinez

Loading

Deblintrake09 commented Nov 30, 2022 •

edited

Loading