Add tests for invalid config of github and office365 modules

[TomasTurina]

Related issue
wazuh/wazuh#4983

Description

This PR includes:

• Tests for github module configuration.
• Tests for office365 module configuration.

Tests

• Proven that tests pass when they have to pass.
• Proven that tests fail when they have to fail.

• Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
• Python codebase is documented following the Google Style for Python docstrings.
• The test is documented in wazuh-qa/docs.
• provision_documentation.sh generate the docs without

[spothound]

I'm reviewing this.

Wazuh branch	Tested commit	Revision
dev-office365-module	d5925fc81c32829b5f153b1e020386e14a1c8ac9	0.commitd5925fc

Testing

test_github

• Build: https://devel.ci.wazuh.info/view/Tests/job/Test_integration/805/console 🔵

Centos

Ubuntu

test_office

• Build: https://devel.ci.wazuh.info/view/Tests/job/Test_integration/806/console 🔵

Centos

Ubuntu

Review notes

• I've detected some unused import and I have asked for their removal.
• I am going to tests test_github and test_office suites in the Jenkins environment.
• To run these new tests on Jenkins it is necessary to add their definitions to pipelineHelper.groovy, this is an small issue, I've open it on jenkins repository https://github.com/wazuh/wazuh-jenkins/issues/2637 and added the change myself here https://github.com/wazuh/wazuh-jenkins/pull/2638 to test them.

[spothound]

Ok, @TomasTurina, the code seems perfect to me, I've just noticed some unused import that I would like to remove. Also, I see some duplicated code that we may merge to make it more maintainable and readable, just a suggestion.

Finally, I have detected that those tests require the wazuh_modules.debug=2 value set in internal options to work. We are deprecating the option to add internal options on Jenkins, currently, we're encouraging the team to use a fixture to automatically set the required internal options before running the tests, so I would like to ask you to add this fixture to remove the requirement of setting this option previous to the test.

You have an example on how to do this here:

wazuh-qa/tests/integration/test_logcollector/test_location_custom_sockets/test_location_custom_sockets.py

Line 32 in e5d6020

local_internal_options = {

Please have all of this in consideration and ask us for review again when you finish making changes to the branch.

Best regards.

[spothound]

The requested changes were applied by TomasTaurina and now I am going to launch automatic tests again to confirm that now everything (including the automatic internal option configuration) works as expected.

Wazuh branch	Tested commit	Revision
dev-office365-module	d5925fc81c32829b5f153b1e020386e14a1c8ac9	0.commitd5925fc

Testing

test_github

https://devel.ci.wazuh.info/job/Test_integration/814/console

Centos

Ubuntu

test_office

https://devel.ci.wazuh.info/job/Test_integration/815/console

Centos

Ubuntu

[spothound]

Awesome job, thank you very much!