Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QACTL enhancements and fixes related to provisioning #1715

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

jotacarma90
Copy link
Member

@jotacarma90 jotacarma90 commented Aug 12, 2021

Related issue
#1708

Description

This PR solves a task list of fixes describes in the issue related.

  • Revision of the code, formatting and documentation.
  • Change some /tmp paths by gettempdir function.
  • Work on the health_check function, make a 1min sleep after installation, and use it.
  • Rename some variables to be more expressive.
  • Formatting and documentation in QAProvisioning.

@jotacarma90 jotacarma90 requested a review from jmv74211 August 12, 2021 11:57
@jotacarma90 jotacarma90 linked an issue Aug 12, 2021 that may be closed by this pull request
15 tasks
@jotacarma90 jotacarma90 mentioned this pull request Aug 12, 2021
15 tasks
@jmv74211 jmv74211 changed the base branch from master to 1533-qa-ctl August 13, 2021 08:51
@jotacarma90 jotacarma90 force-pushed the 1708-qactl-enhancements branch from 9913698 to 9ceaded Compare August 13, 2021 09:09
@jotacarma90 jotacarma90 force-pushed the 1708-qactl-enhancements branch from 9ceaded to 722556e Compare August 13, 2021 09:28
@jotacarma90 jotacarma90 force-pushed the 1708-qactl-enhancements branch from d2d6f33 to 0e86bd2 Compare August 13, 2021 10:10
@jotacarma90 jotacarma90 requested a review from jmv74211 August 13, 2021 10:14
@jmv74211 jmv74211 merged commit cdcd25f into 1533-qa-ctl Aug 13, 2021
@jmv74211 jmv74211 deleted the 1708-qactl-enhancements branch August 13, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QACTL development improvements
2 participants