Add a new method for obtaining S3 packages #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmv74211
suggested changes
Sep 1, 2021
deps/wazuh_testing/wazuh_testing/data/qactl_conf_validator_schema.json
Outdated
Show resolved
Hide resolved
deps/wazuh_testing/wazuh_testing/data/qactl_conf_validator_schema.json
Outdated
Show resolved
Hide resolved
deps/wazuh_testing/wazuh_testing/data/qactl_conf_validator_schema.json
Outdated
Show resolved
Hide resolved
deps/wazuh_testing/wazuh_testing/qa_ctl/provisioning/qa_provisioning.py
Outdated
Show resolved
Hide resolved
deps/wazuh_testing/wazuh_testing/qa_ctl/provisioning/qa_provisioning.py
Outdated
Show resolved
Hide resolved
jmv74211
force-pushed
the
1809-gen-s3-links-implementation
branch
from
bcadf85 to
2723fb6
Compare
added 2 commits
September 3, 2021 01:34
…/wazuh/wazuh-qa into 1809-gen-s3-links-implementation
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is necessary to implement new functionalities in order to get a new alternative method for getting the packages from the S3 server.
This PR makes the following changes:
Add new fields and conditional requirements in the schema validator for accepting the needed parameters of the new functionality.
Add a new tool for generating s3 package URLs called
s3_package.pyModify the
QAProvisioningimplementation in order to add a new alternative method for getting the s3 package if needed.There is a new tool now called
s3_package.pyThere is a new way to get the s3 packages if needed
The schema validator now validates new fields
Tasks
The tasks made for achieving this new implementation are listed in the issue itself.
However, the last changes are commented in this comment.