Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create file monitoring fixture handler #1833

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Sep 2, 2021

Related issue
#1832

Description

This PR closes #1832. It adds a common Wazuh file monitoring handler fixture for all integration tests.

Usage

In order to use this fixture for the default wazuh log file (ossec.log), it is only necessary to calls it in the desired test. In case of the need to monitor another log file, this can be changed by setting the file_to_monitor variable in the test. For example:

file_to_monitor = API_LOG_FILE_PATH

Tests

  • Proven that this fixture works correctly
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the Google Style for Python docstrings.

juliamagan
juliamagan previously approved these changes Sep 6, 2021
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliamagan
Copy link
Member

We can test these changes before the merge in temporal branch: common-fixtures-testing

jmv74211
jmv74211 previously approved these changes Sep 7, 2021
juliamagan
juliamagan previously approved these changes Sep 7, 2021
@Rebits Rebits dismissed stale reviews from juliamagan and jmv74211 via 3f4d080 September 7, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wazuh log monitor handler fixture
3 participants