Fix test_ignore_valid.py - Add timeout variable #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
damarisg
requested changes
Sep 29, 2021
…to fix_test_ignore_valid_timeout
damarisg
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
| Results | Date | By | Status |
|---|---|---|---|
| ResultsTestIngore2.zip | 2021/09/29 | Seyla | 🟢 |
| ResultsTestIgnore.zip | 2021/09/29 | Seyla | 🟢 |
| ResultsIgnore.zip | 2021/09/30 | Seyla | 🟢 |
This was referenced Sep 30, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration options
Description
During the research phase, tests were failing erratically with Timeout errors from the FileMonitor. By trying out with bigger timeouts, all tests passed.
It was proposed to change the timeout, but the default_timeout variable affects all tests that use the FileMonitor, it temporarily, until tests are reworked, adding a local timeout variable, was a proposed fix.
ignore_valid_timeoutwith a value of 15, and run test. It failedTests
UPDATE 2021/09/29
Description
After committing changes for automating module deactivation for the tests, the tests started to fail. Tests were giving unstable results, failing on tests that had already passed.
After creating a new test environment from scratch on branch
1873-4.2.1-fim-windows-agentwith the most recent changes, and testing with disabled modules. All tests passed with the default timeout of 10 seconds.On the latest commit on the branch, the only change applied, is modifying the
yamlfiles to automate module deactivation. Running the tests with some of the modules running, causes fail state.Test
Update 2021/09/29 - 2
1873-4.2.1-fim-windows-agentbranch into working branch.