Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_windows_audit_interval on windows 10 systems #1996

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

Deblintrake09
Copy link
Contributor

@Deblintrake09 Deblintrake09 commented Oct 6, 2021

Related issue
#1973

Description

During testing and debugging it was found that tests failed on Windows 10 systems, because the SACL was not properly retrieved from the file. On Windows 7 and Windows Server 2016, for example, the tests passed. It is thought that there might have occurred a change in the way Windows 10 retrieves that information, so the test needs to be refactored to work properly.

In the meantime, the test will be skipped, only on Windows 10 systems.

Configuration options

Pipeline parameters

Jenkins branch QA branch
v4.2.1-rc1 1873-4.2.1-fim-windows-agent

Environment

Provider Box OS CPU Memory
Vagrant "gusztavvargadr/windows-10" Windows 2 2048
Vagrant "jacqinthebox/windowsserver2016" Windows 2 2048

Tests

Round OS - Manager/Agent - Module Date By Reports Notes
R1 Windows 10 - Agent - test_fim/test_files/test_windows_audit_interval 2021/10/06 @Deblintrake09 🟢 -
R2 Windows 10 - Agent - test_fim/test_files/test_windows_audit_interval 2021/10/06 @Deblintrake09 🟢 -
R3 Windows 10 - Agent - test_fim/test_files/test_windows_audit_interval 2021/10/06 @Deblintrake09 🟢 -
  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.

@Deblintrake09 Deblintrake09 linked an issue Oct 6, 2021 that may be closed by this pull request
4 tasks
@Deblintrake09 Deblintrake09 self-assigned this Oct 6, 2021
@Deblintrake09 Deblintrake09 requested a review from damarisg October 6, 2021 17:15
Copy link
Member

@damarisg damarisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attach the last results:

Results Date by Status
ResultsAudit.zip 2021/10/06 Seyla 🟢
ResultsAudit2.zip 2021/10/06 Seyla 🟢
ResultsAudit3.zip 2021/10/06 Seyla 🟢

@damarisg damarisg merged commit 72c919c into 1873-4.2.1-fim-windows-agent Oct 6, 2021
@damarisg damarisg deleted the 1973-windows-audit-interval branch October 6, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIM Windows Agent - Case: Windows audit interval changed
2 participants