-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_macos_log_format_only_future_event #2027
Merged
Rebits
merged 8 commits into
1329-4.3.0-macOS-logcollector
from
2022-fix-macos-logcollector-tests
Oct 15, 2021
Merged
Fix test_macos_log_format_only_future_event #2027
Rebits
merged 8 commits into
1329-4.3.0-macOS-logcollector
from
2022-fix-macos-logcollector-tests
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add query value in order to avoid FileMonitor error
These tests are being tested with the rest of the tests of #1329 in a temporal branch: PackageTestingtest_logcollector/test_macos
|
As these tests passed, we are going to merge them into PackageTestingtest_logcollector/test_macos/test_format_basic.py
test_logcollector/test_macos/test_format_only_future_events.py
|
juliamagan
changed the base branch from
master
to
1329-4.3.0-macOS-logcollector
October 14, 2021 20:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
tests/integration/test_logcollector/test_macos/test_macos_format_only_future_events.py
. It also, refactor the following tests in order to avoid the use of the remote simulator:tests/integration/test_logcollector/test_macos/test_macos_format_basic.py
tests/integration/test_logcollector/test_macos/test_macos_format_only_future_events.py
.Configuration options
In order to fit new standards, these tests now autoconfigure themself, but in order to run the module it is necessary to use the following
local_internal_options
Testing
11/10/2021
Package
Testing
tests/integration/test_logcollector/test_macos
Tests
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py
.provision_documentation.sh
generate the docs without errors.