Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_macos_log_format_only_future_event #2027

Merged

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Oct 11, 2021

Related issue
#2022

Description

This PR fixes tests/integration/test_logcollector/test_macos/test_macos_format_only_future_events.py. It also, refactor the following tests in order to avoid the use of the remote simulator:

  • tests/integration/test_logcollector/test_macos/test_macos_format_basic.py
  • tests/integration/test_logcollector/test_macos/test_macos_format_only_future_events.py.

Configuration options

In order to fit new standards, these tests now autoconfigure themself, but in order to run the module it is necessary to use the following local_internal_options

logcollector.debug=2
monitord.rotate_log=0
agent.debug=0

Testing

11/10/2021

Package

Version Revision Link
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/macos/wazuh-agent-4.3.0-vr.testing.macos.logcollector.pkg

Testing

tests/integration/test_logcollector/test_macos

OS Local Jenkins Notes
PS1 🟢 🔵
PS2 🟢 🔵
PS3 🟢 🔵

  • 🟢: All pass
  • 🟡: Some warnings
  • 🔴: Some errors/fails
  • 🔵: In progress

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the Google Style for Python docstrings.
  • The test is documented in wazuh-qa/docs.
  • provision_documentation.sh generate the docs without errors.

@juliamagan
Copy link
Member

juliamagan commented Oct 11, 2021

These tests are being tested with the rest of the tests of #1329 in a temporal branch: temp-test-logcollector-macos

Package

Version Revision Link
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/rpm/var/wazuh-manager-4.3.0-vr.testing.macos.logcollector.x86_64.rpm
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/macos/wazuh-agent-4.3.0-vr.testing.macos.logcollector.pkg

Testing

test_logcollector/test_macos

OS Local Jenkins Notes
PS1 🔴
PS2 🔴

  • 🟢: All pass
  • 🟡: Some warnings
  • 🔴: Some errors/fails
  • 🔵: In progress

@juliamagan juliamagan linked an issue Oct 13, 2021 that may be closed by this pull request
@juliamagan
Copy link
Member

juliamagan commented Oct 14, 2021

As these tests passed, we are going to merge them into 1329-4.3.0-macOS-logcollector

Package

Version Revision Link
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/rpm/var/wazuh-manager-4.3.0-vr.testing.macos.logcollector.x86_64.rpm
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/test/4.3/macos/wazuh-agent-4.3.0-vr.testing.macos.logcollector.pkg

Testing

test_logcollector/test_macos/test_format_basic.py

OS Local Jenkins Notes
PS1 🟢 🟢
PS2 🟢 🟢
PS2 🟢 🟢

test_logcollector/test_macos/test_format_only_future_events.py

OS Local Jenkins Notes
PS1 🟢 🟢
PS2 🟢 🟢
PS2 🟢 🟢

  • 🟢: All pass
  • 🟡: Some warnings
  • 🔴: Some errors/fails
  • 🔵: In progress

@juliamagan juliamagan changed the base branch from master to 1329-4.3.0-macOS-logcollector October 14, 2021 20:02
@Rebits Rebits self-assigned this Oct 15, 2021
@Rebits Rebits merged commit 580d59e into 1329-4.3.0-macOS-logcollector Oct 15, 2021
@Rebits Rebits deleted the 2022-fix-macos-logcollector-tests branch October 15, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS format only-future-events tests fails
2 participants