Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1873 disable test affected by 1602 #2049

Merged
merged 4 commits into from
Oct 15, 2021
Merged

1873 disable test affected by 1602 #2049

merged 4 commits into from
Oct 15, 2021

Conversation

damarisg
Copy link
Member

@damarisg damarisg commented Oct 15, 2021 •
edited
Loading

Related issue
#1873

Description

This changes are applied because on Local execution some test are affected by #1602, but there are other test that locally works without problems but on Jenkins Vm failed for problems with services this isse is wazuh/wazuh#9298

Logs example

Tests Results Date By
test_fim/ 🟢 2021/10/15 Seyla
test_fim/ 🟢 2021/10/15 Seyla
test_fim/ 🟢 2021/10/15 Seyla

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.

@damarisg damarisg linked an issue Oct 15, 2021 that may be closed by this pull request
FIM - Windows Agent in 4.2.1 #1873
Closed
@damarisg
Copy link
Member Author

damarisg commented Oct 15, 2021 •
edited by danisan90
Loading

Results of Review:

Tests Results Date By Notes
test_fim/ 🟢 2021/10/15 Daniela --fim_mode="realtime" --fim_mode="whodata" fim_mode="scheduled"
test_fim/ 🟢 2021/10/15 Daniela --fim_mode="realtime" --fim_mode="whodata

@Deblintrake09
Copy link
Contributor

Results of Review:

Tests Results Date By Notes
test_fim/ 🟢 2021/10/15 @Deblintrake09 --fim_mode="realtime" --fim_mode="whodata"

danisan90
danisan90 approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@danisan90 danisan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results in this comment.

Deblintrake09
Deblintrake09 approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@Deblintrake09 Deblintrake09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results in the comments

@damarisg damarisg merged commit 9a29b34 into 1873-4.2.1-fim-windows-agent Oct 15, 2021
@damarisg damarisg deleted the 1873-disable-test-affected-by-1602 branch October 15, 2021 18:33
@damarisg damarisg mentioned this pull request Oct 15, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danisan90 danisan90 danisan90 approved these changes

@Deblintrake09 Deblintrake09 Deblintrake09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIM - Windows Agent in 4.2.1
3 participants
@damarisg @Deblintrake09 @danisan90