Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expected force option from the received request in the agent_enrollment system tests #2289

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

yanazaeva
Copy link
Contributor

@yanazaeva yanazaeva commented Dec 1, 2021

Related issue
#2283

Description

This closes #2283. The aim of this PR is to update the expected log in the agent_enrollment system test. Before 4.3.0 version the expected request contained an int type force field, but in 4.3.0, it is no longer necessary to specify this value as the default one, or the established one will be taken from the master. We will only receive this field if we manually specify it in the request.

@davidjiglesias davidjiglesias self-requested a review December 9, 2021 10:44
Copy link
Member

@davidjiglesias davidjiglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some further investigation about the second error. That timeout might be an indication that the agent is taking more time to restart in wazuh v4.3.0 than it should, or more than we are currently accepting.

@Rebits
Copy link
Member

Rebits commented Dec 15, 2021

15/12/21

test_agent_enrollment.py Report
R1 🟢
R2 🟢
R3 🟢

Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snaow snaow merged commit 73ce4b8 into master Dec 16, 2021
@snaow snaow deleted the feature/2283-update-logs-according-to-release branch December 16, 2021 15:03
@snaow snaow mentioned this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate AssertionErrors happening in agent_enrollment test
5 participants