IT Wazuh DB: Add coverage to new commands #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dámaris <seyla.gomez@wazuh.com>
This reverts commit 5154dde.
…/wazuh-qa into 2532-wazuh-db-commands
IT 2532- Test set_agent_groups WDB command
IT 2532 - Test get-groups-integrity WDB command
IT 2532- Test global backup WDB command and configs
13 tasks
Tests Results
|
Deblintrake09
previously approved these changes
Mar 16, 2022
damarisg
commented
Mar 16, 2022
Comment on lines
54
to
69
| def get_list_of_content_yml(file_path, filter, list=[]): | ||
| """Read a YAML file from a given path, return a list with the YAML data | ||
| after apply filter | ||
|
|
||
| Args: | ||
| file_path (str): Path of the YAML file to be readed | ||
| filter (str): filder to extract some part of yaml | ||
| list: a list with previous information | ||
|
|
||
| Returns: | ||
| list: Yaml structure. | ||
| """ | ||
| list.append((read_yaml(file_path), file_path + filter)) | ||
| return list | ||
|
|
||
|
|
There was a problem hiding this comment.
If we don't use this method but this block is repeat on each test,
with open(messages_file) as f:
module_tests.append((yaml.safe_load(f), messages_file.split('_')[0]))
Could we add this content on a this method an use it on each test?
Deblintrake09
approved these changes
Mar 16, 2022
damarisg
changed the base branch from
master
to
it-wazuh-db-migration-of-agent-groups-files
6 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New changes in Wazuh DB add new commands to cover:
Attached is the list of PRs who worked on each of the commands, there you can find in detail each of the implemented cases.
Configuration options
Local Internal Options: No Local Internal Options used
Required
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.