Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT: VDT - Add test_providers cases for SUSE Linux Enterprise #2820

Conversation

CamiRomero
Copy link
Contributor

@CamiRomero CamiRomero commented Apr 22, 2022

Related issue
2808

Description

As part of #2792, it is necessary to add cases in the test_providers suite related to SUSE Linux Enterprise support for the Wazuh Vulnerability Detector module.

Test added:

  • Test enabled/disabled: Check that the provider's feeds start downloading when activated.
  • Test missing os: Test the behavior when the tag is omitted. Check failure if the tag is required, and in case it is not, it starts downloading the feeds as normal
  • Test OS: Test that it starts downloading the feeds of the specified OS.
  • Test update from year: Test if the feed is updated from a specific date. If the option does not apply, check warning warning.
  • Test update interval: Test that the feed is updated at the specified interval

Configuration options

local_internal_options

wazuh_modules.debug=2
monitord.rotate_log=0

Tests Results

Test Path Os/Type Execution Type Results Date By
test/integration/test_vulnerability_detector/test_providers CentOS - Manager Jenkins 🟢🟢🟢 28/04/2022 @CamiRomero
  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the Google Style for Python docstrings.
  • The test is documented in wazuh-qa/docs.

@damarisg damarisg linked an issue Apr 28, 2022 that may be closed by this pull request
7 tasks
PROVIDER: 'suse'
metadata:
provider_name: 'SUSE Linux Enterprise'
os: ['']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correct. However, we must add the supported OS.

Suggested change
os: ['']
os: ['11-server', '12-server', '15-server', '11-desktop', '12-desktop', '15-desktop', '']

Comment on lines 40 to 45
- SUSE Linux Enterprise Desktop 11
- SUSE Linux Enterprise Desktop 12
- SUSE Linux Enterprise Desktop 15
- SUSE Linux Enterprise Server 11
- SUSE Linux Enterprise Server 12
- SUSE Linux Enterprise Server 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we only test SUSE 11 desktop. It should remove the others.

Suggested change
- SUSE Linux Enterprise Desktop 11
- SUSE Linux Enterprise Desktop 12
- SUSE Linux Enterprise Desktop 15
- SUSE Linux Enterprise Server 11
- SUSE Linux Enterprise Server 12
- SUSE Linux Enterprise Server 15
- SUSE Linux Enterprise Desktop 11

Comment on lines 40 to 45
- SUSE Linux Enterprise Desktop 11
- SUSE Linux Enterprise Desktop 12
- SUSE Linux Enterprise Desktop 15
- SUSE Linux Enterprise Server 11
- SUSE Linux Enterprise Server 12
- SUSE Linux Enterprise Server 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we only test SUSE 12 Server. It should remove the others.

Suggested change
- SUSE Linux Enterprise Desktop 11
- SUSE Linux Enterprise Desktop 12
- SUSE Linux Enterprise Desktop 15
- SUSE Linux Enterprise Server 11
- SUSE Linux Enterprise Server 12
- SUSE Linux Enterprise Server 15
- SUSE Linux Enterprise Server 12

Copy link
Member

@damarisg damarisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests Results

Test Path Os/Type Execution Type Results Date By
test/integration/test_vulnerability_detector/test_providers CentOS - Manager Jenkins 🟢🟢🟢 28/04/2022 Seyla

@damarisg damarisg merged commit 05f9c07 into 2792-add-support-for-SUSE-OVAL-in-Vulnerability-Detector Apr 28, 2022
@damarisg damarisg deleted the 2808-test-providers-for-suse-linux-enterprise branch April 28, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test_providers cases for SUSE Linux Enterprise
2 participants