Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking the agent status in wazuh-manager when it is closed gracefullyv2 #4146

Merged
merged 22 commits into from
Sep 8, 2023
Merged

Checking the agent status in wazuh-manager when it is closed gracefullyv2 #4146

merged 22 commits into from
Sep 8, 2023

Conversation

pro-akim
Copy link
Member

@pro-akim pro-akim commented May 3, 2023 •
edited
Loading

Related issue
#3709

Description

Wazuh manager should receive correctly the agent closing message. The closing process will happen gracefully, therefore, this test is designed to check the status of the agent in wazuh-manager (agent_control) after the shutdown.

Added

-test_shutdown_message

Tester Test path Jenkins Local OS Commit Notes
@pro-akim (Developer) tests/system/test_shutdown_message/test_shutdown_message.py ⚫⚫⚫ 🟢🟢🟢 Debian 502f4d5 Nothing to highlight
@user (Reviewer) ⚫⚫⚫ ⚫⚫⚫ Nothing to highlight

@pro-akim pro-akim requested a review from juliamagan May 3, 2023 09:38
@pro-akim pro-akim changed the title Checking the agent status in wazuh-manager when it is closed gracefully Checking the agent status in wazuh-manager when it is closed gracefullyv2 May 3, 2023
@pro-akim pro-akim linked an issue May 3, 2023 that may be closed by this pull request
Add coverage to allow shutdown message processing even though socket is closed #3709
Closed
1 task
@pro-akim pro-akim mentioned this pull request May 3, 2023
Closed
@pro-akim pro-akim self-assigned this May 3, 2023
juliamagan
juliamagan requested changes Jul 3, 2023
View reviewed changes
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, but some changes are required. In addition, this PR includes changes that have not been used in the test, so they may be from another development.

CHANGELOG.md Outdated Show resolved Hide resolved
tests/system/test_shutdown_message/test_shutdown_message.py Outdated Show resolved Hide resolved
tests/system/test_shutdown_message/test_shutdown_message.py Outdated Show resolved Hide resolved
tests/system/test_shutdown_message/test_shutdown_message.py Outdated Show resolved Hide resolved
tests/system/test_shutdown_message/test_shutdown_message.py Outdated Show resolved Hide resolved
@pro-akim pro-akim requested a review from juliamagan July 4, 2023 08:00
juliamagan
juliamagan requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to test the changes again

@pro-akim
Copy link
Member Author

pro-akim commented Jul 4, 2023

04/07/2023

Tests were run yesterday.
Reports updated and tables filled with new data.

@pro-akim pro-akim requested a review from juliamagan July 4, 2023 13:15
juliamagan
juliamagan previously approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

damarisg
damarisg reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@damarisg damarisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in our systems testing.
I see that the issue of documenting varies a lot. I believe that these are things that we will improve from now on once they are defined.

damarisg
damarisg previously approved these changes Jul 5, 2023
View reviewed changes
@pro-akim pro-akim dismissed stale reviews from damarisg and juliamagan via 710b305 July 11, 2023 18:16
@pro-akim pro-akim changed the base branch from 4.6.0 to master September 8, 2023 08:24
davidjiglesias
davidjiglesias previously approved these changes Sep 8, 2023
View reviewed changes
@davidjiglesias davidjiglesias merged commit 907ac22 into master Sep 8, 2023
@davidjiglesias davidjiglesias deleted the 3709-shutdown_messagev2 branch September 8, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjiglesias davidjiglesias davidjiglesias approved these changes

@juliamagan juliamagan juliamagan left review comments

@damarisg damarisg damarisg left review comments

Assignees

@pro-akim pro-akim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add coverage to allow shutdown message processing even though socket is closed
4 participants
@pro-akim @damarisg @davidjiglesias @juliamagan