Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests after removing references to the legacy vulnerability detector module #4872

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

pereyra-m
Copy link
Member

@pereyra-m pereyra-m commented Jan 18, 2024

Related issue
wazuh/wazuh#21303

Description

This PR removes all the tests related to the vuln_cves table because now it's deprecated.
Also, the column triaged in both sys_programs and sys_osinfo tables was removed; and the agent's DB schema was updated.


Testing performed

Tester Test path Jenkins Local OS Commit Notes
@pereyra-m (Matias Pereyra) tests/integration/test_wazuh_db/ Not run yet 🟢 Ubuntu 22.04 11a5a33dd5 The linting check fails because of some long lines and it isn't related to these changes.

@pereyra-m pereyra-m requested a review from Rebits January 18, 2024 02:10
@pereyra-m pereyra-m self-assigned this Jan 18, 2024
@pereyra-m pereyra-m force-pushed the enhancement/21303-vuln-det-references branch from 6f04988 to 420d2ff Compare January 18, 2024 04:40
Rebits
Rebits previously approved these changes Jan 23, 2024
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebasfalcone sebasfalcone force-pushed the enhancement/21303-vuln-det-references branch from ba229ce to 0cd43de Compare January 25, 2024 19:37
@sebasfalcone sebasfalcone force-pushed the enhancement/21303-vuln-det-references branch from 0cd43de to cbc4053 Compare January 26, 2024 13:49
@sebasfalcone
Copy link
Member

@Dwordcito, @Rebits told us that there is no problem with the linting.

The tests are passing again with these changes

@Dwordcito Dwordcito self-requested a review January 30, 2024 02:34
@Dwordcito Dwordcito merged commit 07c1a0e into 4.8.0 Jan 30, 2024
4 of 6 checks passed
@Dwordcito Dwordcito deleted the enhancement/21303-vuln-det-references branch January 30, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all references of the legacy vulnerability detector module
4 participants