Implement support for the installation/uninstallation of npm packages #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
santipadilla
changed the title
4 tasks
1 task
1 task
MARCOSD4
requested changes
Mar 25, 2024
Rebits
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Good job, Just a few minor adjustments are needed.
It's advisable to create new methods named install_npm_package and remove_npm_package. Doing so will enhance the maintainability, testability, and readability of the code. This change will make it necessary to perform minor changes in the remote_operation module to handle which method is going to be used for each package
Rebits
requested changes
Apr 1, 2024
Co-authored-by: Víctor Rebollo Pérez <victorrebollop@gmail.com>
Rebits
requested changes
Apr 4, 2024
|
@Rebits Modified here: 5e8d1ea and check in this comment: #5130 (comment) |
juliamagan
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the support to have the option to install and uninstall packages with npm on all endpoints.