Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter alerts and logs by timestamp #5157

Merged

Conversation

juliamagan
Copy link
Member

@juliamagan juliamagan commented Mar 27, 2024

Related issue
#5108

Description

  • We have fixed a Grafana package wrong with the expected version.
  • Added not to ignore timeout errors in waiters.
  • Fixed a regex
  • Removed extra steps in the setup

Testing performed

Validation Jenkins Local Commit Notes
end_to_end/test_vulnerability_detector 🟡 🟡 225bb88 Known issue: #5173 and #5175

@juliamagan juliamagan self-assigned this Mar 27, 2024
@juliamagan juliamagan linked an issue Mar 27, 2024 that may be closed by this pull request
@juliamagan juliamagan marked this pull request as ready for review April 3, 2024 09:17
@rafabailon rafabailon self-requested a review April 3, 2024 09:43
Copy link
Member

@rafabailon rafabailon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Some minor changes are requested

@davidjiglesias davidjiglesias merged commit 6eb396d into enhancement/vd-e2e-tests Apr 5, 2024
@davidjiglesias davidjiglesias deleted the bug/5108-filter-timestamp-alerts branch April 5, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerts are not being filtered by timestamp
4 participants