Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change greater than timestamp by detected_at in vulnerability index #5266

Merged
merged 10 commits into from
Apr 25, 2024
Merged

Fix change greater than timestamp by detected_at in vulnerability index #5266

merged 10 commits into from
Apr 25, 2024

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Apr 18, 2024 •
edited
Loading

Description

This PR updates the index API functions in order to use the detected_by field instead of the timestamp field. For alerts, it continues to utilize the same field for filtering by timestamp.

Testing performed

Environment

manager1:
    roles: [manager, filebeat, indexer]
    os: ubuntu_22
    type: master

agent3:
    roles: [agent]
    os: ubuntu_22
    manager: manager1

Testing

Validation Jenkins Local OS Commit Notes
⚫ 🟢 Nothing to highlight

@Rebits Rebits self-assigned this Apr 18, 2024
@Rebits Rebits linked an issue Apr 18, 2024 that may be closed by this pull request
Update E2E method to filter wazuh-states-vulnerabilities by detected_at instead of timestamp #5239
Closed
@Rebits Rebits mentioned this pull request Apr 18, 2024
Closed
@Rebits Rebits marked this pull request as ready for review April 19, 2024 11:56
juliamagan

This comment was marked as duplicate.

Sign in to view

juliamagan
juliamagan requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! But remember to add the changelog entry.

@Rebits Rebits changed the title Fix change greater than timestamp by detected_at in vulenraiblity index Fix change greater than timestamp by detected_at in vulnerability index Apr 23, 2024
juliamagan
juliamagan approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidjiglesias davidjiglesias merged commit 5c4efff into 4.8.0 Apr 25, 2024
0 of 2 checks passed
@davidjiglesias davidjiglesias deleted the fix/5239-vd-timestamp-filter branch April 25, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliamagan juliamagan juliamagan approved these changes

Assignees

@Rebits Rebits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update E2E method to filter wazuh-states-vulnerabilities by detected_at instead of timestamp
3 participants
@Rebits @juliamagan @davidjiglesias