Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API script file name #5351

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

GGP1
Copy link
Member

@GGP1 GGP1 commented May 8, 2024

Description

Updates the API script file name.

Tests

Checks from the main PR: wazuh/wazuh#23222

@GGP1 GGP1 self-assigned this May 8, 2024
Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rauldpm rauldpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GGP1
Copy link
Member Author

GGP1 commented May 20, 2024

Maybe missing? Please check it

https://github.com/wazuh/wazuh-qa/blob/4.9.0/deps/wazuh_testing/wazuh_testing/__init__.py#L56

Please check this list https://github.com/search?q=repo%3Awazuh%2Fwazuh-qa+%22apid%22&type=code&p=1

The API_DAEMON variable is used to restart the API by killing its processes and starting it again using the binary. No reference to the python script has been found. SImilarly, all the others wazuh-apid relate to the daemon/module and not the script.

@GGP1 GGP1 requested a review from rauldpm May 20, 2024 15:38
Copy link
Member

@rauldpm rauldpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

PR checks do not launch integration tests

@davidjiglesias davidjiglesias merged commit 8c6f0dc into 4.9.0 Jun 4, 2024
@davidjiglesias davidjiglesias deleted the fix/22608-processes-cleanup branch June 4, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wazuh-apid blindly killing pid (found in wazuh-apid.pid) after a sudden reboot
4 participants