Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase E2E Vulnerability detection change manager test timeout #5414

Merged
merged 3 commits into from
May 23, 2024

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented May 22, 2024

Description

This PR enhances the E2E Vulnerability Detection Change Manager test by increasing the timeout value. The timeout now dynamically adjusts based on the number of agents in the environment, making the testing logic more scalable. This improvement allows for the addition of more agents without encountering erratic errors caused by timeout issues.


Testing performed

Validation Jenkins Local OS Commit Notes
🚫 🟢 Nothing to highlight
Result analysis

@Rebits Rebits self-assigned this May 22, 2024
@Rebits Rebits linked an issue May 22, 2024 that may be closed by this pull request
2 tasks
@Rebits Rebits marked this pull request as ready for review May 22, 2024 11:42
rafabailon
rafabailon previously approved these changes May 22, 2024
Copy link
Member

@rafabailon rafabailon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliamagan juliamagan merged commit 4be8d40 into 4.8.0 May 23, 2024
1 of 2 checks passed
@juliamagan juliamagan deleted the fix/5413-increase-change-manager-test-timeout branch May 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase E2E Vulnerability Detection change manager timeout
3 participants