Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify VD E2E tests to use package feed #5739

Merged
merged 13 commits into from
Sep 17, 2024

Conversation

santipadilla
Copy link
Member

@santipadilla santipadilla commented Sep 13, 2024

Closing/Related Issue

Closes #5700

Description

Modify VD E2E tests to use package feed instead of CTI feed.

Tasks

  • Test that the suggested change works as expected.
  • If it works, implement this change to E2E.

Evidences

Note: More tests performed in this commentary.

rafabailon
rafabailon previously approved these changes Sep 13, 2024
Copy link
Member

@rafabailon rafabailon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the feed is going to fail to download, we must take these logs into account so that the tests are not marked as failed. For example in this build, we can see that test test_first_syscollector_scan has failed because the following logs appear, which should be expected:

"manager1": {
        "ERROR": [],
        "CRITICAL": [],
        "WARNING": [
            "2024/09/12 12:41:57 wazuh-modulesd:content-updater[82704] offlineDownloader.hpp:90 at operator()(): WARNING: Error '-1' when downloading file: Couldn't connect to server."
        ]
    }

However, this is a WARNING level log, and they were disabled in #5699. Please, update your base branch and execute the tests again.

@santipadilla
Copy link
Member Author

@juliamagan juliamagan merged commit e9d1712 into 4.9.1 Sep 17, 2024
@juliamagan juliamagan deleted the enhancement/5700-use-package-feed-in-VD-test branch September 17, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the feed address to avoid its downloading and updating
3 participants