Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex value comparison #5845

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

GGP1
Copy link
Member

@GGP1 GGP1 commented Nov 27, 2024

Description

Closes wazuh/wazuh#27052.

Fixes a bug in the test_cluster_sync.py file that caused the test to fail.

Testing performed

Manual test

It uses the artifacts from the related issue description.

(venv) gasti@gasti:~/work/wazuh-qa/tests/reliability/test_cluster/test_cluster_logs/test_cluster_sync$ python3 -m pytest test_cluster_sync.py --artifacts_path='/home/gasti/Downloads/artifacts'
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.10.14, pytest-7.1.2, pluggy-1.5.0
rootdir: /home/gasti/work/wazuh-qa/tests, configfile: pytest.ini
plugins: metadata-3.1.1, testinfra-5.0.0, html-3.1.1
collected 1 item                                                                                                                                                                                                                             

test_cluster_sync.py .                                                                                                                                                                                                                 [100%]

============================================================================================================= 1 passed in 59.39s =============================================================================================================

@GGP1 GGP1 self-assigned this Nov 27, 2024
@GGP1 GGP1 linked an issue Nov 27, 2024 that may be closed by this pull request
@javiersanchz javiersanchz self-requested a review November 27, 2024 13:56
Copy link
Member

@javiersanchz javiersanchz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

The research is accurate, and the changes are correct.

It was confirmed that the test passes successfully.

LGTM!

Copy link
Member

@fdalmaup fdalmaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliamagan juliamagan merged commit cfc2885 into 4.10.0 Nov 28, 2024
@juliamagan juliamagan deleted the bug/27052-cluster-sync-counter branch November 28, 2024 16:29
@Rebits Rebits mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate error in test_cluster_sync
4 participants