comments

wbo4958 · Sep 11, 2024 · b8d0deb · b8d0deb
1 parent 0feb48f
commit b8d0deb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/...ages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostClassifier.scala b/...ages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostClassifier.scala
@@ -47,8 +47,8 @@ class XGBoostClassifier(override val uid: String,
   private var numberClasses = 0
 
   private def validateObjective(dataset: Dataset[_]): Unit = {
-    // If the objective is set explicitly, it must be in binaryClassificationObjs and
-    // multiClassificationObjs
+    // If the objective is set explicitly, it must be in BINARY_CLASSIFICATION_OBJS and
+    // MULTICLASSIFICATION_OBJS
     val obj = if (isSet(objective)) {
       val tmpObj = getObjective
       val supportedObjs = BINARY_CLASSIFICATION_OBJS.toSeq ++ MULTICLASSIFICATION_OBJS.toSeq

diff --git a/...kages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostEstimator.scala b/...kages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostEstimator.scala
@@ -492,7 +492,7 @@ private[spark] trait XGBoostModel[M <: XGBoostModel[M]] extends Model[M] with ML
     val predContrib = addToSchema(contribPredictionCol)
 
     var predRaw = false
-    // For classification case, the tranformed col is probability,
+    // For classification case, the transformed col is probability,
     // while for others, it's the prediction value.
     var predTmp = false
     this match {
@@ -503,7 +503,7 @@ private[spark] trait XGBoostModel[M <: XGBoostModel[M]] extends Model[M] with ML
         if (isDefinedNonEmpty(predictionCol)) {
           // Let's use transformed col to calculate the prediction
           if (!predTmp) {
-            // Add the transformed col for predition
+            // Add the transformed col for prediction
             schema = schema.add(
               StructField(TMP_TRANSFORMED_COL, ArrayType(FloatType)))
             predTmp = true

diff --git a/...kages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostRegressor.scala b/...kages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoostRegressor.scala
@@ -47,8 +47,7 @@ class XGBoostRegressor(override val uid: String,
   override protected[spark] def validate(dataset: Dataset[_]): Unit = {
     super.validate(dataset)
 
-    // If the objective is set explicitly, it must be in binaryClassificationObjs and
-    // multiClassificationObjs
+    // If the objective is set explicitly, it must be in REGRESSION_OBJS
     if (isSet(objective)) {
       val tmpObj = getObjective
       require(REGRESSION_OBJS.contains(tmpObj),