Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The new package control version is ignoring all packages which I override some files #1155

Closed
evandrocoan opened this issue Sep 20, 2016 · 5 comments
Closed

The new package control version is ignoring all packages which I override some files #1155

evandrocoan opened this issue Sep 20, 2016 · 5 comments
Labels
enhancement
Milestone
Package Control 4.0

Comments

@evandrocoan
Copy link

evandrocoan commented Sep 20, 2016 •
edited
Loading

The new package control version is ignoring all packages which I override some files at the User Package folder

I override some default plugin files as these:
image

With the older package control, prior to today update (19/09/2016), everything was working fine. Now those packages as the above Google Spell Checker are not being installed on a clean fresh install I use from here: https://github.com/evandrocoan/SublimeTextStudio#installation

If you follow those instructions, and let the Package Control install, it will miss several packages as the above. All the affected packages are marked as installed by this new Package Manger.

I have to uninstall them one by one, which will delete my configuration files as the ones above for the Google Spell Checker, and install them again, and restore my just deleted user settings at the Package folder. For now I will update those installation steps to go over this problem, only adding the user files after the Package Manger finishes installing everything.

How to revert to the older version?

If you are running into a bug, please read https://packagecontrol.io/docs/troubleshooting
before submitting an issue here.
Bug reports must include a debug log. The Troubleshooting page explains how to capture one.
@wbond
Copy link
Owner

wbond commented Sep 20, 2016

If Package Control finds packages installed already, it won't try to overwrite them. What you should do is install the base packages first, then install your overrides.

The old version of Package Control functioned the same way. Most likely you just didn't notice because you added the overrides after installing the packages.

@evandrocoan
Copy link
Author

Maybe I did not noticed, however this is one of the awesome Sublime's
feature, I may override anything I want to from de default packages, or
from the package manager packages at the Installed Package's folder. So,
there is reason to why do not download the .sublime-package to the
Installed Package's folder just because there is some files at the Use
Package's folder. I am just saying to put the .sublime-packages at the
Installed Package's folder, and let me naturaly override what I want to on
the User Package's folder.

On Tue, Sep 20, 2016, 00:53 Will Bond notifications@github.com wrote:

If Package Control finds packages installed already, it won't try to
overwrite them. What you should do is install the base packages first, then
install your overrides.

The old version of Package Control functioned the same way. Most likely
you just didn't notice because you added the overrides after installing the
packages.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1155 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFFcvqoKR4-ycrfcWybypEKoHhf6mv8Pks5qr1iWgaJpZM4KBLr9
.

Att, Evandro Coan

@wbond
Copy link
Owner

wbond commented Sep 20, 2016

The reason is that we cant assume a folder existing means it is an override. It could be a custom package with the same name. Overrides also don't exist in ST2.

There would need to be functionality added to detect something such as a file named .sublime-package-override, and if that exists, allow installing a package "underneath" the existing folder.

evandrocoan added a commit to evandrocoan/PackagesManager that referenced this issue Sep 21, 2016
@evandrocoan
Added the setting detection for config.sublime-package-override
d1c175c 
When the exists the file `config.sublime-package-override`, the
package control attempts to install the package to `Installed
Packages`, instead of mark the package as installed.

See the issue: wbond#1155
@evandrocoan evandrocoan mentioned this issue Sep 21, 2016
Closed
@evandrocoan
Copy link
Author

I added two new code lines, and now it is working as I want to.

evandrocoan added a commit to evandrocoan/PackagesManager that referenced this issue Sep 25, 2016
@evandrocoan
Added the setting detection for config.sublime-package-override
0613629 
When the exists the file `config.sublime-package-override`, the
package control attempts to install the package to `Installed
Packages`, instead of mark the package as installed.

See the issue: wbond#1155
deathaxe added a commit that referenced this issue Mar 19, 2023
@deathaxe
Refactor missing package installation
743fc2e 
Fixes #1155

This commit re-uses existing `PackageTaskRunner` functionality to
create a list of missing packages and install them. The benefit is more
detailed logging and increased re-usability of existing code.

This commit provides the following major changes in behavior:

1. It does no longer track renamed packages. The `installed_packages`
   setting must contain up-to-date package names.

   It might be surprising to see packages being installed, which are
   not in the list of `installed_packages`. Maybe private packages are
   named like ones from official channel used to be in the past.
   If renaming is to be taken into account each entry would need to be
   checked for being available first.

2. It overwrites existing unmanaged packages.

   The `installed_packages` setting normally contains packages, which
   have been installed via and are managed by Package Control.

   Any package in that list can be considered as "to be managed".

   Custom unmanaged packages should not appear in that list as the only
   way they get there was a user adding them manually.

   Hence it can be considered safe to take the `installed_packages` and
   ask ST to install them and overwrite possibly existing unmanaged
   packages, as it is likely enough for them to be overrides.

   Note: git/hg repositories are not treated as overrides nor are they
         treated as managed packages.

3. All remaining missing packages are removed from `installed_packages`
   once all available packages have been installed in order to prevent
   ST from re-trying after each start.
deathaxe added a commit that referenced this issue Mar 19, 2023
@deathaxe
Refactor missing package installation
04c0422 
Fixes #1155

This commit re-uses existing `PackageTaskRunner` functionality to
create a list of missing packages and install them. The benefit is more
detailed logging and increased re-usability of existing code.

This commit provides the following major changes in behavior:

1. It does no longer track renamed packages. The `installed_packages`
   setting must contain up-to-date package names.

   It might be surprising to see packages being installed, which are
   not in the list of `installed_packages`. Maybe private packages are
   named like ones from official channel used to be in the past.
   If renaming is to be taken into account each entry would need to be
   checked for being available first.

2. It overwrites existing unmanaged packages.

   The `installed_packages` setting normally contains packages, which
   have been installed via and are managed by Package Control.

   Any package in that list can be considered as "to be managed".

   Custom unmanaged packages should not appear in that list as the only
   way they get there was a user adding them manually.

   Hence it can be considered safe to take the `installed_packages` and
   ask ST to install them and overwrite possibly existing unmanaged
   packages, as it is likely enough for them to be overrides.

   Note: git/hg repositories are not treated as overrides nor are they
         treated as managed packages.

3. All remaining missing packages are removed from `installed_packages`
   once all available packages have been installed in order to prevent
   ST from re-trying after each start.
deathaxe added a commit that referenced this issue Mar 19, 2023
@deathaxe
Refactor missing package installation
6a2766d 
Fixes #1155

This commit re-uses existing `PackageTaskRunner` functionality to
create a list of missing packages and install them. The benefit is more
detailed logging and increased re-usability of existing code.

This commit provides the following major changes in behavior:

1. It does no longer track renamed packages. The `installed_packages`
   setting must contain up-to-date package names.

   It might be surprising to see packages being installed, which are
   not in the list of `installed_packages`. Maybe private packages are
   named like ones from official channel used to be in the past.
   If renaming is to be taken into account each entry would need to be
   checked for being available first.

2. It overwrites existing unmanaged packages.

   The `installed_packages` setting normally contains packages, which
   have been installed via and are managed by Package Control.

   Any package in that list can be considered as "to be managed".

   Custom unmanaged packages should not appear in that list as the only
   way they get there was a user adding them manually.

   Hence it can be considered safe to take the `installed_packages` and
   ask ST to install them and overwrite possibly existing unmanaged
   packages, as it is likely enough for them to be overrides.

   Note: git/hg repositories are not treated as overrides nor are they
         treated as managed packages.

3. All remaining missing packages are removed from `installed_packages`
   once all available packages have been installed in order to prevent
   ST from re-trying after each start.
deathaxe added a commit that referenced this issue Mar 20, 2023
@deathaxe
Refactor missing package installation
46f61a3 
Fixes #1155

This commit re-uses existing `PackageTaskRunner` functionality to
create a list of missing packages and install them. The benefit is more
detailed logging and increased re-usability of existing code.

This commit provides the following major changes in behavior:

1. It does no longer track renamed packages. The `installed_packages`
   setting must contain up-to-date package names.

   It might be surprising to see packages being installed, which are
   not in the list of `installed_packages`. Maybe private packages are
   named like ones from official channel used to be in the past.
   If renaming is to be taken into account each entry would need to be
   checked for being available first.

2. It overwrites existing unmanaged packages.

   The `installed_packages` setting normally contains packages, which
   have been installed via and are managed by Package Control.

   Any package in that list can be considered as "to be managed".

   Custom unmanaged packages should not appear in that list as the only
   way they get there was a user adding them manually.

   Hence it can be considered safe to take the `installed_packages` and
   ask ST to install them and overwrite possibly existing unmanaged
   packages, as it is likely enough for them to be overrides.

   Note: git/hg repositories are not treated as overrides nor are they
         treated as managed packages.

3. All remaining missing packages are removed from `installed_packages`
   once all available packages have been installed in order to prevent
   ST from re-trying after each start.
deathaxe added a commit that referenced this issue Mar 20, 2023
@deathaxe
Refactor missing package installation
a9d5e97 
Fixes #1155

This commit re-uses existing `PackageTaskRunner` functionality to
create a list of missing packages and install them. The benefit is more
detailed logging and increased re-usability of existing code.

This commit provides the following major changes in behavior:

1. It does no longer track renamed packages. The `installed_packages`
   setting must contain up-to-date package names.

   It might be surprising to see packages being installed, which are
   not in the list of `installed_packages`. Maybe private packages are
   named like ones from official channel used to be in the past.
   If renaming is to be taken into account each entry would need to be
   checked for being available first.

2. It overwrites existing unmanaged packages.

   The `installed_packages` setting normally contains packages, which
   have been installed via and are managed by Package Control.

   Any package in that list can be considered as "to be managed".

   Custom unmanaged packages should not appear in that list as the only
   way they get there was a user adding them manually.

   Hence it can be considered safe to take the `installed_packages` and
   ask ST to install them and overwrite possibly existing unmanaged
   packages, as it is likely enough for them to be overrides.

   Note: git/hg repositories are not treated as overrides nor are they
         treated as managed packages.

3. All remaining missing packages are removed from `installed_packages`
   once all available packages have been installed in order to prevent
   ST from re-trying after each start.
@deathaxe deathaxe added this to the Package Control 4.0 milestone Nov 26, 2023
@deathaxe
Copy link
Collaborator

Fixed by Package Control 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Package Control 4.0
Development

No branches or pull requests
3 participants
@wbond @evandrocoan @deathaxe