[Feature Request]: Allow relative paths in repository json spec #1329
Milestone
Comments
deathaxe
added a commit
that referenced
this issue
Mar 19, 2023
Fixes #1329 This commit enables RepositoryProvider to resolve relative URLs in - package-level `details` keys - release-level `base` and `url` keys using the repository's location as root. Example: A repository https://github.com/user/repository/repository.json with following content: { "name": "my-package", "details": "../my-package" "releases": [ { "url": "./downloads/my-package.sublime-package" } ] } is resolved to... { "name": "my-package", "details": "https://github.com/user/my-package" "releases": [ { "url": "https://github.com/user/repository/downloads/my-package.sublime-package" } ] }
deathaxe
added a commit
that referenced
this issue
Mar 19, 2023
Fixes #1329 This commit enables RepositoryProvider to resolve relative URLs in - package-level `details` keys - release-level `base` and `url` keys using the repository's location as root. Example: A repository https://github.com/user/repository/repository.json with following content: { "name": "my-package", "details": "../my-package" "releases": [ { "url": "./downloads/my-package.sublime-package" } ] } is resolved to... { "name": "my-package", "details": "https://github.com/user/my-package" "releases": [ { "url": "https://github.com/user/repository/downloads/my-package.sublime-package" } ] }
deathaxe
added a commit
that referenced
this issue
Mar 20, 2023
Fixes #1329 This commit enables RepositoryProvider to resolve relative URLs in - package-level `details` keys - release-level `base` and `url` keys using the repository's location as root. Example: A repository https://github.com/user/repository/repository.json with following content: { "name": "my-package", "details": "../my-package" "releases": [ { "url": "./downloads/my-package.sublime-package" } ] } is resolved to... { "name": "my-package", "details": "https://github.com/user/my-package" "releases": [ { "url": "https://github.com/user/repository/downloads/my-package.sublime-package" } ] }
deathaxe
added a commit
that referenced
this issue
Mar 20, 2023
Fixes #1329 This commit enables RepositoryProvider to resolve relative URLs in - package-level `details` keys - release-level `base` and `url` keys using the repository's location as root. Example: A repository https://github.com/user/repository/repository.json with following content: { "name": "my-package", "details": "../my-package" "releases": [ { "url": "./downloads/my-package.sublime-package" } ] } is resolved to... { "name": "my-package", "details": "https://github.com/user/my-package" "releases": [ { "url": "https://github.com/user/repository/downloads/my-package.sublime-package" } ] }
|
Oh, awesome! Thanks
…On Sat, Dec 2, 2023, at 8:22 AM, deathaxe wrote:
Closed #1329 <#1329> as completed via802c37f.
—
Reply to this email directly, view it on GitHub <#1329 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEJOIQ4HNB6WWNRIB3NFALYHNBSFAVCNFSM4EPHPFP2U5DIOJSWCZC7NNSXTWQAEJEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW4OZRGEYTEOJSGAYDQMJS>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The repositories.json spec allows the
urlfor a specific release to be defined. Would it be possible to allow that url to be a relative url that is relative to the repository.json?Use case:
We host a custom repository.json that is accessible via two different vhosts:
internal.foo.com/repository.jsonandroaming.foo.com/repository.json. Ideally the repository.json would allow for the releaseurlfor a plugin to be defined as./my-plugin-v1.0.0.zip. This would than translate tointernal.foo.com/my-plugin-v1.0.0.zipif theinternalvhost repository.json was added to package control.The text was updated successfully, but these errors were encountered: