Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retina theme #5549

Merged
merged 1 commit into from
Jun 13, 2016
Merged

Add Retina theme #5549

merged 1 commit into from
Jun 13, 2016

Conversation

braver
Copy link
Collaborator

@braver braver commented May 29, 2016

The default theme recreated with @2x graphics

@FichteFoll
Copy link
Collaborator

I highly suggest moving all assets down to a subfolder for your own (and my) sanity. And adjusting the paths in the theme file ofc.

Other than that, I don't understand the purpose of this package. The default theme already ships with high-dpi icons and assets. It was even the first theme of all to support the new high-dpi assets, for obvious reasons.

@braver
Copy link
Collaborator Author

braver commented Jun 2, 2016

I'm sorry, but you're coming of as annoyed by this package. I put my spare time in it and want to share it. There is no ill intent.

I highly suggest moving all assets down to a subfolder for your own (and my) sanity

My sanity is best served with the files in the exact same place as the original default theme. This makes it trivial to match changes to the default theme simply by diffing the two folders. If this adversely affects your sanity I'm sorry.

The default theme already ships with high-dpi icons and assets.

It has some yes, but a lot of vital assets don't have @2x variations. These include all images for the tabs and tabbar, the x icon and all icons for the buttons on the search&replace panel. If you use tabs (instead of the open file list) on a Retina Macbook, the lack of resolution in these assets is glaringly obvious. They're rough and blurry. I've discussed this on the forums and github and apparently the original artwork is not high resolution enough to create @2x variations and apparently the creator is MIA.

It was even the first theme of all to support the new high-dpi assets, for obvious reasons.

This might be true, but it didn't stop them from adding new low resolution icon for the new panel switcher. Obviously no one is committed to keeping the assets retina compatible.

Other than that, I don't understand the purpose of this package.

I know most people, especially developers, don't care about rough or blurry graphics. However, people used to think Sublime was a beautiful editor. If you open it now on a Retina Macbook, it looks like and old relic.

BTW. I reached out to @sublimehq and @wbond about this and offered them the high dpi assets and the source files for them. No response.

So that's the purpose of this package.

@FichteFoll
Copy link
Collaborator

It has some yes, but a lot of vital assets don't have @2x variations.

Thanks for that clarification. This was not obvious to me through your PR description or the readme.

I was not offended by your package. We just have some quality standards regarding packages on the default channel that I would like to keep up for as long as it's managable. Few package managers can say that about themselves since they are mostly not reviewed at all.

@FichteFoll FichteFoll merged commit cee76af into wbond:master Jun 13, 2016
@braver
Copy link
Collaborator Author

braver commented Jun 13, 2016

Few package managers can say that about themselves since they are mostly not reviewed at all.

Definitely, and it's a key strength of packagecontrol that someone (i.e. you) is putting in the effort. So sorry about assuming things and thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants