argocd: make chart versions configurable + cleanup #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dati18
approved these changes
Nov 8, 2024
deer-wmde
force-pushed
the
de/argo-ui-use-helm
branch
from
6e0501a to
4c29cc3
Compare
|
rebased and added missing changelog documentation of what happened in between, another review please |
|
after conversation with @tarrow I added configurable chart versions to this for the applications as well as the app-of-apps chart itself |
deer-wmde
changed the title
tarrow
approved these changes
Dec 9, 2024
|
I know we looked through this a bit together already and I therefore made all the comments back then I wanted to. Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
should get merged after #171