Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $crate from core macro calls #1

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Remove $crate from core macro calls #1

merged 2 commits into from
Jan 7, 2021

Conversation

MarijnS95
Copy link
Contributor

$crate was likely imported by accident from core. Both a trailing semicolon and format string (+ optional arguments) would fail to compile with this in place.

assert_eq!/assert_ne! is the wrong macro to forward to, this should end
up in the hex variant here.
Likely a copy-paste error when importing assert_eq!/assert_ne! from
core.
@wcampbell0x2a
Copy link
Owner

thanks!

@wcampbell0x2a wcampbell0x2a merged commit 1f93309 into wcampbell0x2a:master Jan 7, 2021
@wcampbell0x2a
Copy link
Owner

Released with v0.1.1

@MarijnS95
Copy link
Contributor Author

Thanks! Also for immediately releasing a new version!

One more thing: I guess you're using this to compare byte arrays and need 02 padding and 0x[ff, ff, ff] instead of the 0x in-line per item? We'd prefer to use just {:#x} (or something like this) but would probably have to add another macro for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants