Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --script-mode / -s and fix --dir as well as add tests #183

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

bradennapier
Copy link
Contributor

@bradennapier bradennapier commented Jul 23, 2020

ts-node team is discussing making --script-mode a default setting in the near future. Also, since the --dir option was configured incorrectly, ts-node-dev had some cases that were impossible to make work properly. This PR adds the following:

  • support for --script-mode and -s from ts-node
    • uses the same logic used by ts-node to handle the arguments here
  • support for --dir which currently is seutp as a boolean rather than a string so it doesn't work properly
  • tests for all cases provided including error cases.

It is easy to install since there is no compilation for this project - yarn add --dev git://github.com/bradennapier/ts-node-dev.git#feature/script-mode" should work if you want to use this before it is published. Hopefully since it is quite critical in many cases it will get merged quickly :-)

@bradennapier bradennapier changed the title Add --script-mode / -s and fix --dir as well as add tests Add --script-mode / -s and fix --dir as well as add tests Jul 23, 2020
@wclr wclr merged commit f1fd8a8 into wclr:master Jul 23, 2020
@wclr
Copy link
Owner

wclr commented Jul 23, 2020

Ok I believe this should work) Thanks!

@bradennapier
Copy link
Contributor Author

bradennapier commented Jul 23, 2020

No problem, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants