-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat:Add feedback button (#106) #116
Open
littlestar642
wants to merge
2
commits into
wdlsvnit:master
Choose a base branch
from
littlestar642:feedback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlestar642
force-pushed
the
feedback
branch
from
February 24, 2018 20:07
db7c092
to
4a15066
Compare
lunaticmonk
requested changes
Feb 25, 2018
public/css/styles.css
Outdated
} | ||
|
||
#feedBtn{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no camelcasing
public/js/chat.js
Outdated
|
||
cancel.addEventListener('click', () => { | ||
let confirm = document.querySelector('#confirm'); | ||
confirm.classList.remove('visible'); | ||
}); | ||
|
||
cancelFeed.addEventListener('click', () => { | ||
let confirmFeedback = document.querySelector('#feedback') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why two diff vars to select #feedback?
littlestar642
force-pushed
the
feedback
branch
3 times, most recently
from
February 25, 2018 14:05
3e93cef
to
3f2db0d
Compare
littlestar642
force-pushed
the
feedback
branch
from
February 25, 2018 14:06
3f2db0d
to
dfee7eb
Compare
littlestar642
changed the title
Feat:Add feedback button
Feat:Add feedback button (#106)
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
Deployment available at
https://salty-peak-60673.herokuapp.com/