Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Replace (cid:x) values for Latin charset #111

Merged
merged 11 commits into from
Feb 20, 2024

Conversation

krishnasism
Copy link
Contributor

As mentioned in the issue #106, pdfminer.six has problems when faced with (cid:x) values when the font is not embedded.

We can manually overwrite the (cid:x) values based on the charset. For now added only LATIN charset.

@krishnasism
Copy link
Contributor Author

Thinking about it. What do you think about allowing users to pass their custom charsets 🤔 @aptakhin for example

charset = {128: "@"}

pdf = HotPdf(file, decoder=Decoder(charset))

We can have our internal ones that the user can use or they can pass their custom ones. More freedom, and we don't need to maintain all charsets.

@aptakhin
Copy link
Collaborator

Thinking about it. What do you think about allowing users to pass their custom charsets 🤔 @aptakhin for example

charset = {128: "@"}

pdf = HotPdf(file, decoder=Decoder(charset))

We can have our internal ones that the user can use or they can pass their custom ones. More freedom, and we don't need to maintain all charsets.

Yes, I think it might be good that we allow users to make their own Decoder if our standard wasn't so useful.

@krishnasism krishnasism merged commit 879d814 into main Feb 20, 2024
4 checks passed
@krishnasism krishnasism deleted the feature/replace-cid-not-replaced branch February 20, 2024 08:52
krishnasism added a commit that referenced this pull request Feb 21, 2024
…replaced

feature: Replace (cid:x) values for Latin charset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants